Conversation
|
I think the So inside the template code it could reference values, rather than relying on the <h1>{import.meta.env.RADFISH_APP_NAME}<h1>Additionally, I think the plugin could also make use of the |
…or automatic CSS injection
There was a problem hiding this comment.
This should probably be moved to the packages directory and published to the registry before themes are released.
There was a problem hiding this comment.
Thanks! I'll work on this
Move the theme plugin from templates/react-javascript/plugins/ into packages/vite-plugin-radfish-theme/ as @nmfs-radfish/vite-plugin-radfish-theme. - Split monolithic plugin into focused modules (config, scss, compile, server, build, utils) - Add unit tests (44 tests) for pure functions - Add GitHub Actions publish workflow - Update template to import from the new package - Add package to monorepo workspaces
feat: extract vite-plugin-radfish-theme into standalone package
| max-width: 110px; | ||
| } | ||
| } | ||
|
|
There was a problem hiding this comment.
This will fix the logo resizing:
.header-logo-link { display: flex; align-items: center; }
.header-logo { max-width: 210px; width: 100%; }
.usa-navbar { display: flex; justify-content: space-between; align-items: center; width: 100%; height: 5rem; }
.usa-menu-btn { height: 100%; }
remove:
@media (max-width: 63.99em) { .header-logo { max-width: 110px; } }
There was a problem hiding this comment.
@jmtorneros Thanks! I've made updates so that our NOAA theme looks more like the NOAA website.
| } | ||
| } | ||
|
|
||
| @media (min-width: 64em) { |
There was a problem hiding this comment.
Also recommend changing the colors on the usa-nav__inner
to look like:
3 participants
No description provided.