Skip to content

Fix too high effect_costs#105

Open
BrentWHR wants to merge 17 commits intomainfrom
#102
Open

Fix too high effect_costs#105
BrentWHR wants to merge 17 commits intomainfrom
#102

Conversation

@BrentWHR
Copy link
Contributor

Where effect_costs in bbwp_measures was higher than 2. The values have been devided by ten as there likely was a decimal error.

This column is now also numeric instead of integer.

Resolves #102
Closes BBWP-147

@BrentWHR BrentWHR requested a review from yuki-nmi September 25, 2025 14:20
@BrentWHR BrentWHR self-assigned this Sep 25, 2025
Copy link
Contributor

@yuki-nmi yuki-nmi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you mention where you got the bbwp_measures.csv from? There are different versions of the csv, so it would be nice if we know exactly where it came from.

@BrentWHR
Copy link
Contributor Author

Can you mention where you got the bbwp_measures.csv from? There are different versions of the csv, so it would be nice if we know exactly where it came from.

This PR adds a new bbwp_measures.csv in data-raw. This file is obtained by running data-raw/bbwp_measures.R which starts with reading dev/measures.csv and dev/bbwp_measures.csv and processes these to finally write to data-raw/bbwp_measures.csv and data/bbwp_measures.rda

@BrentWHR BrentWHR requested a review from yuki-nmi November 3, 2025 11:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Measures with extreme effect_cost

2 participants