Skip to content

Check instanceof not exact type match #22

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
JulianKnodt wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Check instanceof not exact type match #22

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions src/robust_laplacian/core.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,13 +5,13 @@
def mesh_laplacian(verts, faces, mollify_factor=1e-5):

## Validate input
if type(verts) is not np.ndarray:
raise ValueError("`verts` should be a numpy array")
if not isinstance(verts, np.ndarray):
raise ValueError("`verts` should be an instance of numpy array")
if (len(verts.shape) != 2) or (verts.shape[1] != 3):
raise ValueError("`verts` should have shape (V,3), shape is " + str(verts.shape))

if type(faces) is not np.ndarray:
raise ValueError("`faces` should be a numpy array")
if not isinstance(faces, np.ndarray):
raise ValueError(f"`faces` should be an instance of numpy array")
if (len(faces.shape) != 2) or (faces.shape[1] != 3):
raise ValueError("`faces` should have shape (F,3), shape is " + str(faces.shape))

Expand Down