Draft
Conversation
9fec02b to
7b66110
Compare
910ea1d to
ba4d6c1
Compare
c5c4c76 to
1df20dc
Compare
Merged
26f06e1 to
cf173a3
Compare
651780f to
9da1c4b
Compare
fa4e272 to
8dc375d
Compare
Co-authored-by: Clément Renault <renault.cle@gmail.com>
88b8217 to
1b53f4a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is enabling Hannoy to utilize the new nested read transactions feature, allowing Meilisearch to build with it as well. We have seen significant improvements when it is necessary to read uncommitted changes in parallel.
I bumped hannoy to
v0.1.3-nested-rtxnsand would like to release this pre-version on crates.io soon. I also bumped the Rust version tov1.89in the different CI jobs.Note that this PR is based on #107, as we need both features in Meilisearch. However, as long as #107 is merged into main, we will be able to rebase on it.