[ML-Agent for Android]: Dummy ml-agent added#53
Merged
jaeyun-jung merged 1 commit intonnstreamer:mainfrom Jan 14, 2025
Merged
Conversation
songgot
requested review from
again4you,
anyj0527,
gichan-jang,
jaeyun-jung,
jijoongmoon,
myungjoo,
niley7464,
wooksong and
yeonykim2
as code owners
myungjoo
reviewed
Jan 10, 2025
| * @brief A set of exported ml-agent interfaces for managing pipelines, models, and other service. | ||
| * @see https://github.com/nnstreamer/deviceMLOps.MLAgent | ||
| * @author Wook Song <wook16.song@samsung.com> | ||
| * @bug No known bugs except for NYI items |
Member
There was a problem hiding this comment.
- Provide a proper description.
- If this provides the same interface as https://github.com/nnstreamer/deviceMLOps.MLAgent/blob/main/daemon/include/mlops-agent-interface.h , do NOT create another header. It will break future build when someone updates the interface. Share the SAME file.
Contributor
Author
There was a problem hiding this comment.
Okay, I will do that, thank you.
jaeyun-jung
reviewed
Jan 13, 2025
| * @param[in] pipeline_desc A stringified description of the pipeline. | ||
| * @return 0 on success, a negative error value if failed. | ||
| */ | ||
| int ml_agent_pipeline_set_description (const char *name, const char *pipeline_desc); |
Contributor
There was a problem hiding this comment.
I suggest adding jni folder and using common header for android build.
We don't need to change meson for android.
jni/mlops-agent.mk
MLOPS_AGENT_SRCS := $(MLOPS_AGENT_ROOT)/daemon/mlops-agent-android.c
Then, including MLOPS_AGENT_SRCS when building android library in api repo.
Contributor
Author
There was a problem hiding this comment.
Honestly, I don't 100% understand it. I'll study and try it.
songgot
force-pushed
the
dummy_agent
branch
4 times, most recently
from
f165a83 to
c705382
Compare
jaeyun-jung
approved these changes
Jan 14, 2025
Add dummy ml-agent-android Signed-off-by: hyunil park <hyunil46.park@samsung.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add dummy ml-agent-android
Support Ubuntu Meson build