Skip to content

[Coverity] Fix possible overflow #9

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jaeyun-jung merged 1 commit into from
Mar 17, 2025
Merged

[Coverity] Fix possible overflow #9

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 18 additions & 0 deletions src/hal-api-ml.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -71,6 +71,15 @@ hal_ml_scan_backends (void)
_D ("Scanning available HAL ML backends...");

hal_ml_backend_count = hal_common_get_backend_count (HAL_MODULE_ML);
if (hal_ml_backend_count < 0) {
_E ("Failed to get backend count");
return -1;
}

if (hal_ml_backend_count == 0) {
return 0;
}

_D ("hal_ml_backend_count: %d", hal_ml_backend_count);

hal_ml_backend_names = (char **) malloc (sizeof (char *) * hal_ml_backend_count);
Expand Down Expand Up @@ -180,6 +189,15 @@ hal_ml_create (const char *backend_name, hal_ml_h *handle)
static int scanned = 1;
if (scanned == 1) {
scanned = hal_ml_scan_backends ();
if (scanned < 0) {
_E ("Failed to scan backends");
return HAL_ML_ERROR_RUNTIME_ERROR;
}
}

if (hal_ml_backend_count == 0) {
_E ("There is no available backends");
return HAL_ML_ERROR_NOT_SUPPORTED;
}

_I ("Initializing backend %s", backend_name);
Expand Down
2 changes: 1 addition & 1 deletion tests/ml-haltests.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,7 @@ TEST (HAL_ML, create_n)

hal_ml_h ml;
EXPECT_EQ (hal_ml_create (nullptr, &ml), HAL_ML_ERROR_INVALID_PARAMETER);
EXPECT_EQ (hal_ml_create ("there_is_no_available_backend", &ml), HAL_ML_ERROR_INVALID_PARAMETER);
EXPECT_NE (hal_ml_create ("there_is_no_available_backend", &ml), HAL_ML_ERROR_NONE);
}

TEST (HAL_ML, destroy_n)
Expand Down
Loading