Draft
Conversation
n9-machine-user
added
breaking-change
This commit introduces significant changes to the replay endpoints and their associated validation logic. The following updates have been made: 1. **Endpoint Updates**: - Added new endpoints for `Cancel`, `Delete`, `DeleteAll`, `List`, and `GetStatus` operations. - Refactored the `Replay` endpoint to `Run` for better clarity and alignment with its functionality. - Introduced a helper function `handleReplayError` to centralize error handling logic for replay-related operations. 2. **Request and Validation Changes**: - Renamed `ReplayRequest` to `RunRequest` and updated its fields for consistency (`Slo` to `SLO`, `ReplayDuration` to `Duration`, etc.). - Added new request types: `DeleteRequest`, `CancelRequest`, and `GetStatusRequest`. - Updated validation rules to reflect the new structure and naming conventions. - Enhanced validation logic to ensure only one of `duration` or `startDate` is set, and added checks for future dates. 3. **Response Updates**: - Updated `ReplayWithStatus` to use `SLO` instead of `Slo`. - Introduced a new response type `ReplayListItem` for listing replay items. 4. **Test Updates**: - Refactored test cases to align with the new request and response structures. - Updated test names and assertions to reflect the renaming and added validation rules. 5. **Miscellaneous**: - Updated helper functions and constants to align with the new naming conventions. - Improved error messages and validation error codes for better clarity.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Describe what is the motivation behind the proposed changes.
If possible reference the current solution/state of affairs.
Summary
Recap of changed code.
Related changes
List related changes from other PRs (if any).
Testing
main.gowhich takes advantage of the introduced changes is preferred (if possible and useful).Release Notes
If this change should be part of the Release Notes,
replace this entire paragraph with 1-3 sentences about the changes.
Otherwise, you MUST remove this section entirely.
Does this PR contain any breaking changes?
If so, add
## Breaking Changesheader and list the introduced changes there.Breaking Changes
sdk/modelspackage has been removed. The Replay related models have been transferred tosdk/endpoints/replay/v1package.