feat: add account_group_id to ThousandEyes metric spec#530
Open
greg-agacinski wants to merge 2 commits intomainfrom
Open
feat: add account_group_id to ThousandEyes metric spec#530greg-agacinski wants to merge 2 commits intomainfrom
greg-agacinski wants to merge 2 commits intomainfrom
Conversation
greg-agacinski
requested review from
daniel-zelazny,
nieomylnieja and
skrolikiewicz
as code owners
n9-machine-user
added
enhancement
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Support
account_group_idfield for ThousandEyes metric spec in SLO resources, allowing users to specify which ThousandEyes account group a test belongs to.Summary
account_group_idoptional attribute to the ThousandEyes schema blockAccountGroupIDfield toThousandEyesModelstructthousandEyesToModelandmodelToThousandEyesconversion functionsnobl9-godependency to include the new field supportRelated Changes
Testing
account_group_idcan be set in a ThousandEyes metric spec blockaccount_group_iddoes not break existing configurationsRelease Notes
Added
account_group_idoptional field to ThousandEyes metric spec in SLO resources.