[DO NOT REVIEW] CI testing for ILLEGAL error occasionally seen in CI
#2608
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When diagnosing this issue, some sources point to the possibility of an architecture mismatch, i.e. we generate code that assumes a particular instruction is available, and if said instruction isn't available we get a `SIGILL`and the `ILLEGAL` error from CTest we've seen. Without `--iree-llvmcpu-target-cpu=host` IREE will not attempt to use any advanced CPU arch features making an arch mismatch impossible. If we see the same `ILLEGAL` error without the `--iree-llvmcpu-target-cpu=host` flag, we can be reasonably assured that arch mismatch isn't the culprit.
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2608 +/- ##
=======================================
Coverage ? 77.55%
=======================================
Files ? 264
Lines ? 25192
Branches ? 0
=======================================
Hits ? 19537
Misses ? 5655
Partials ? 0 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
We need to actually know how frequently this might happen to know if we *haven't* seen it in X number of runs than it's probably not a problem.
This reverts commit 3afee71.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When diagnosing this issue, some sources point to the possibility of an architecture mismatch, i.e. we generate code that assumes a particular instruction is available, and if said instruction isn't available we get a
SIGILLand theILLEGALerror from CTest we've seen. Without--iree-llvmcpu-target-cpu=hostIREE will not attempt to use any advanced CPU arch features making an arch mismatch impossible. If we see the sameILLEGALerror without the--iree-llvmcpu-target-cpu=hostflag, we can be reasonably assured that arch mismatch isn't the culprit.