Skip to content

Conversation

@RattataKing
Copy link
Contributor

This PR expands the logging function to support data analysis of the candidate search space and candidate_ordering performance evaluation.
Tuner now records candidate info such as tuning knob configurations, position in benchmark queue, final result ranking, etc.
The collected tuning records will be exported to a CSV file under the tuning base folder.

@codecov-commenter
Copy link

codecov-commenter commented Nov 12, 2025

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

❌ Patch coverage is 66.32653% with 33 lines in your changes missing coverage. Please review.
⚠️ Please upload report for BASE (main@9726c06). Learn more about missing BASE report.

Files with missing lines Patch % Lines
sharktuner/sharktuner/libtuner.py 0.00% 22 Missing ⚠️
sharktuner/sharktuner/candidate_ordering.py 85.10% 7 Missing ⚠️
sharktuner/dispatch_tuner/dispatch_tuner.py 0.00% 4 Missing ⚠️
❗ Your organization needs to install the Codecov GitHub app to enable full functionality.
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2666   +/-   ##
=======================================
  Coverage        ?   77.03%           
=======================================
  Files           ?      291           
  Lines           ?    28892           
  Branches        ?        0           
=======================================
  Hits            ?    22257           
  Misses          ?     6635           
  Partials        ?        0           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Member

@kuhar kuhar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good overall, just a few minor comments

RattataKing and others added 2 commits November 18, 2025 11:27
Co-authored-by: Jakub Kuderski <[email protected]>
@bangtianliu bangtianliu enabled auto-merge (squash) November 18, 2025 18:14
@bangtianliu bangtianliu merged commit 75db566 into nod-ai:main Nov 18, 2025
37 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants