fix: update deps, finally fix keep-alive tests

Signed-off-by: Charlike Mike Reagent <[email protected]>

Author: tunnckoCore

package.json

@@ -29,8 +29,8 @@
     "eslint-plugin-prettier": "^3.1.2",
     "prettier": "^1.19.1",
     "prettier-plugin-pkgjson": "^0.2.0",
-    "request": "^2.11.4",
-    "urun": "^0.0.6",
+    "request": "^2.88.0",
+    "urun": "^0.0.8",
     "utest": "^0.0.8"
   }
 }

test/standalone/test-keep-alive-error.js

@@ -8,7 +8,7 @@ const formidable = require('../../src/index');
 let ok = 0;
 let errors = 0;
 
-const PORT = 13532;
+const PORT = 0;
 const server = http.createServer((req, res) => {
   const form = formidable();
   form.on('error', () => {
@@ -24,45 +24,50 @@ const server = http.createServer((req, res) => {
   form.parse(req);
 });
 
-server.listen(PORT, 'localhost', () => {
+server.listen(PORT, () => {
   const choosenPort = server.address().port;
   const url = `http://localhost:${choosenPort}`;
   console.log('Server up and running at:', url);
 
   const client = net.createConnection(choosenPort);
 
-  // first send malformed post upload
+  // first send malformed (boundary / hyphens) post upload
   client.write(
     'POST /upload-test HTTP/1.1\r\n' +
       'Host: localhost\r\n' +
       'Connection: keep-alive\r\n' +
       'Content-Type: multipart/form-data; boundary=----aaa\r\n' +
       'Content-Length: 10011\r\n\r\n' +
       '------aaa\n\r',
-  ); // expected \r\n
+  );
 
   setTimeout(() => {
     const buf = Buffer.alloc(10000);
     buf.fill('a');
     client.write(buf);
-
-    // correct post upload
-    client.write(
-      'POST /upload-test HTTP/1.1\r\n' +
-        'Host: localhost\r\n' +
-        'Connection: keep-alive\r\n' +
-        'Content-Type: multipart/form-data; boundary=----aaa\r\n' +
-        'Content-Length: 13\r\n\r\n' +
-        '------aaa--\r\n',
-    );
+    client.end();
 
     setTimeout(() => {
-      assert.strictEqual(ok, 1, `should ok count === 1, has: ${ok}`);
-      // TODO: fix it!
-      // assert.strictEqual(errors, 1, 'should errors count === 1, has: ' + errors);
-      console.log('should errors === 1', errors);
-      client.end();
-      server.close();
-    }, 100);
-  }, 100);
+      assert.strictEqual(errors, 1, `should "errors" === 1, has: ${errors}`);
+
+      const clientTwo = net.createConnection(choosenPort);
+
+      // correct post upload (with hyphens)
+      clientTwo.write(
+        'POST /upload-test HTTP/1.1\r\n' +
+          'Host: localhost\r\n' +
+          'Connection: keep-alive\r\n' +
+          'Content-Type: multipart/form-data; boundary=----aaa\r\n' +
+          'Content-Length: 13\r\n\r\n' +
+          '------aaa--\r\n',
+      );
+      clientTwo.end();
+
+      setTimeout(() => {
+        assert.strictEqual(ok, 1, `should "ok" count === 1, has: ${ok}`);
+
+        server.close();
+      }, 300);
+    }, 200);
+  }, 150);
 });

yarn.lock

@@ -1354,7 +1354,7 @@ regexpp@^2.0.1:
   resolved "https://registry.yarnpkg.com/regexpp/-/regexpp-2.0.1.tgz#8d19d31cf632482b589049f8281f93dbcba4d07f"
   integrity sha512-lv0M6+TkDVniA3aD1Eg0DVpfU/booSu7Eev3TDO/mZKHBfVjgCGTV4t4buppESEYDtkArYFOxTJWv6S5C+iaNw==
 
-request@^2.11.4:
+request@^2.88.0:
   version "2.88.0"
   resolved "https://registry.yarnpkg.com/request/-/request-2.88.0.tgz#9c2fca4f7d35b592efe57c7f0a55e81052124fef"
   integrity sha512-NAqBSrijGLZdM0WZNsInLJpkJokL72XYjUpnB0iwsRgxh7dB6COrHnTBNwN0E+lHDAJzu7kLAkDeY08z2/A0hg==
@@ -1687,17 +1687,10 @@ uri-js@^4.2.2:
   dependencies:
     punycode "^2.1.0"
 
-urun@^0.0.6:
-  version "0.0.6"
-  resolved "https://registry.yarnpkg.com/urun/-/urun-0.0.6.tgz#e0fa856980367d86bf146e180bc3890320ab1d2f"
-  integrity sha1-4PqFaYA2fYa/FG4YC8OJAyCrHS8=
-  dependencies:
-    utest "0.0.2"
-
-[email protected]:
-  version "0.0.2"
-  resolved "https://registry.yarnpkg.com/utest/-/utest-0.0.2.tgz#3862e2975309ea5de0940444a6c6ee0179726a16"
-  integrity sha1-OGLil1MJ6l3glAREpsbuAXlyahY=
+urun@^0.0.8:
+  version "0.0.8"
+  resolved "https://registry.yarnpkg.com/urun/-/urun-0.0.8.tgz#3799a0293714c1115d326a4e69e2a5f96ee786e2"
+  integrity sha1-N5mgKTcUwRFdMmpOaeKl+W7nhuI=
 
 utest@^0.0.8:
   version "0.0.8"