-
Notifications
You must be signed in to change notification settings - Fork 124
chore: upgrade vite-plus #647
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Caution Review failedThe pull request is closed. Note Other AI code review bot(s) detectedCodeRabbit has detected other AI code review bot(s) in this pull request and will avoid duplicating their findings in the review comments. This may lead to a less comprehensive review. 📝 WalkthroughWalkthroughThe changes introduce Vite+ as the unified web toolchain by updating CI workflows to include linting steps, modifying package.json to add vitest with npm aliasing and pnpm overrides for Vite+ packages, updating vite.config.ts lint configuration paths, and adding documentation on Vite+ usage patterns. Changes
Possibly related PRs
Poem
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes ✨ Finishing touches
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Summary of ChangesHello @fengmk2, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request performs a comprehensive dependency update, with a central focus on upgrading the Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
commit: |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #647 +/- ##
=======================================
Coverage 92.77% 92.77%
=======================================
Files 10 10
Lines 747 747
Branches 233 233
=======================================
Hits 693 693
Misses 51 51
Partials 3 3 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request primarily focuses on upgrading various dependencies, including qs, undici, @types/node, vite-plus, oxfmt, oxlint-tsgolint, oxlint, lightningcss, eventemitter3, and which-typed-array. The pnpm-lock.yaml file has been updated accordingly to reflect these changes and their transitive dependencies. Additionally, the vite.config.ts file includes a minor adjustment to the oxlint configuration path and the removal of a $schema reference in the fmt configuration.
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
|
All alerts resolved. Learn more about Socket for GitHub. This PR previously contained dependency changes with security issues that have been resolved, removed, or ignored. |
d464839 to
7ace79e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR upgrades the project to a newer Vite+ toolchain and aligns related formatter, linter, and test integrations, along with a few direct dependency bumps.
Changes:
- Upgrades
vite-plusand its ecosystem (@voidzero-dev/vite-plus-*,oxfmt,oxlint,oxlint-tsgolint,lightningcss, etc.) viapnpm-lock.yaml, and bumpsqs,undici, and@types/node. - Routes
vitestthrough@voidzero-dev/vite-plus-testusing bothdevDependenciesandoverrides(top-level andpnpm.overrides), and updates@vitest/coverage-v8accordingly. - Adjusts tooling configuration: updates lint config
extendspath, simplifies formatter schema usage, changes lint-staged formatting command, and adds aRun lintstep to the test CI job.
Reviewed changes
Copilot reviewed 4 out of 5 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
vite.config.ts |
Updates lint config to extend from @eggjs/oxlint-config via node_modules and drops the fmt.$schema pointer to match the upgraded oxfmt tooling. |
pnpm-lock.yaml |
Regenerates the lockfile to reflect new Vite+ core/test builds, updated lint/format/runtime dependencies, and adds an overrides entry for vitest. |
package.json |
Bumps qs, undici, and @types/node, wires vitest to @voidzero-dev/vite-plus-test, adds unified overrides for vite/vitest, and updates lint-staged to call vite fmt directly. |
CLAUDE.md |
Adds a blank line before the Vite+ section for formatting consistency. |
.github/workflows/nodejs.yml |
Ensures the matrix test job runs vite run lint before the CI test pipeline, mirroring the typecheck job behavior. |
Files not reviewed (1)
- pnpm-lock.yaml: Language not supported
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Summary by CodeRabbit
Release Notes
New Features
Documentation
Chores
✏️ Tip: You can customize this high-level summary in your review settings.