Skip to content

Propose changing polling to obtain only latest changes #149

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
mrummuka wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Propose changing polling to obtain only latest changes #149

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e0a1ece
Dropbox: test with 1min polling
Jul 31, 2016
3c1d33f
Dropbox in node: reset cursor after every poll (enables polling only …
Jul 31, 2016
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 4 additions & 3 deletions dropbox/dropbox.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,7 @@ module.exports = function(RED) {
function DropboxInNode(n) {
RED.nodes.createNode(this,n);
this.filepattern = n.filepattern || "";
this.checkInterval = n.checkInterval || 600000;
this.checkInterval = n.checkInterval || 60000;
this.dropboxConfig = RED.nodes.getNode(n.dropbox);
var credentials = this.dropboxConfig ? this.dropboxConfig.credentials : {};
if (!credentials.appkey || !credentials.appsecret ||
Expand All @@ -61,10 +61,11 @@ module.exports = function(RED) {
return;
}
node.status({});
if (!node.state) {
if (!node.state) { // when executed for the first time only save cursor
node.state = data.cursor();
}
else {
else {
node.state = data.cursor(); // reset cursor to get only changes since last poll
var changes = data.changes;
for (var i = 0; i < changes.length; i++) {
var change = changes[i];
Expand Down