Skip to content

Remove all reference XML data if any are corrupted #500

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
cjbarth merged 1 commit into from
Apr 24, 2025
Merged

Remove all reference XML data if any are corrupted #500

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions src/signed-xml.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -323,7 +323,11 @@ export class SignedXml {
valid(ated). Put simply: if one fails, they are all not trustworthy.
*/
this.signedReferences = [];
this.references.forEach((ref) => {
ref.signedReference = undefined;
});
// TODO: add this breaking change here later on for even more security: `this.references = [];`

if (callback) {
callback(new Error("Could not validate all references"), false);
return;
Expand Down Expand Up @@ -358,6 +362,9 @@ export class SignedXml {
// but that may cause some breaking changes, so we'll handle that in v7.x.
// If we were validating `signedInfoCanon` first, we wouldn't have to reset this array.
this.signedReferences = [];
this.references.forEach((ref) => {
ref.signedReference = undefined;
});
// TODO: add this breaking change here later on for even more security: `this.references = [];`

if (callback) {
Expand Down