perf: reduce number of requests for username skin lookups#125
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In the last 30 days, more than 30% of requests to Crafthead were using a username instead of a UUID.
Previously, Crafthead would hit Mojang to get this information directly, but recently we swapped to PlayerDB for faster lookups. PlayerDB returns all the needed information in a single request, but we never fully refactored Crafthead to pass this through, so it was doing two round-trips to PlayerDB instead of one, for any username requests.
This will improve performance for any uncached username image requests.