-
-
Notifications
You must be signed in to change notification settings - Fork 8
analysis: add cmake toolchain analysis #9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
mmarchini
wants to merge
3
commits into
nodejs:main
Choose a base branch
from
mmarchini:cmake-toolchain-analysis
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 1 commit
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,52 @@ | ||
# Bazel toolchain analysis | ||
|
||
[CMake](https://cmake.org) is an open-source, cross-platform family of tools | ||
designed to build, test and package software. CMake is used to control the | ||
software compilation process using simple platform and compiler independent | ||
configuration files, and generate native makefiles and workspaces that can be | ||
used in the compiler environment of your choice. | ||
|
||
## Supported platforms | ||
|
||
TODO: test cmake against currently Node.js supported platforms and toolchains | ||
(see [BUILDING.MD](https://github.com/nodejs/node/edit/master/BUILDING.md)). | ||
|
||
### Unsupported platforms | ||
|
||
TODO: see above | ||
|
||
## Pros | ||
|
||
* Widely used by C++ projects (probably the most used toolchain besides of | ||
`make` and `autotools`). | ||
* Easier to upgrade all our dependencies (except V8) and easier to add new | ||
dependencies that use or are compatible with CMake (which is likely based on | ||
previous point) | ||
* It's been around for over two decades | ||
* Due to its popularity, it's the most likely toolchain to support all of our | ||
platforms within our minimum version constraints | ||
|
||
## Cons | ||
|
||
* CMake is not on V8 tree, therefore, V8 upgrades would be just as hard as today | ||
with gyp | ||
|
||
|
||
## Known ports | ||
|
||
* No open source known ports [1^] | ||
|
||
[1^]: It's not a full Node.js port, but | ||
[bnoordhuis/v8-cmake](https://github.com/bnoordhuis/v8-cmake) adds cmake | ||
support to V8 | ||
|
||
## Need more info | ||
|
||
* Would cmake build affect Electron ability to build Node.js with GN in any way? | ||
|
||
## Observations | ||
|
||
* There seems to be positive reception at the idea of cmake for native modules, | ||
having the same build system for building Node.js and its native modules | ||
mmarchini marked this conversation as resolved.
Show resolved
Hide resolved
|
||
* There is the possibility of using cmake to build everything except V8, using | ||
GN to build V8 and then linking it statically to Node.js |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.