Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR enables sparse checkout of the doc/api directory from the nodejs/node repository to potentially speed up CI workflows.
- Adds a
sparse-checkoutspecification under theactions/checkoutstep - Targets only
doc/apito reduce the amount of checked-out files
Comments suppressed due to low confidence (1)
.github/workflows/generate.yml:57
- Consider adding
fetch-depth: 0to ensure the sparse checkout retrieves the necessary commit history, as shallow clones (default depth: 1) may not support sparse-checkout correctly. For example:
- uses: actions/checkout@v3
with:
fetch-depth: 0
sparse-checkout: |
doc/api
sparse-checkout: |
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## main #355 +/- ##
=======================================
Coverage 72.14% 72.14%
=======================================
Files 117 117
Lines 9992 9992
Branches 597 597
=======================================
Hits 7209 7209
Misses 2780 2780
Partials 3 3 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
AugustinMauroy
approved these changes
Jul 16, 2025
1a07f12 to
c5f4884
Compare
Member
Author
|
Requesting fast track. |
Member
Author
|
@ovflowd You approved the fast-track, can you approve the PR, i need an infra approval |
ovflowd
approved these changes
Jul 16, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
(CC @ovflowd)
Let's see if this speeds up the workflows significantly. If not, we can use a shared step, but this may be enough.