-
Notifications
You must be signed in to change notification settings - Fork 17
chore(lint): remove #415
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(lint): remove #415
Conversation
The latest updates on your projects. Learn more about Vercel for GitHub.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR removes the linting functionality from the @node-core/doc-kit
package as part of moving linting capabilities to a separate @node-core/remark-lint
package. This simplifies the doc-kit package by focusing solely on documentation generation.
- Removes all linter-related code including rules, reporters, and context
- Updates the markdown parser to remove linter parameter and calls
- Removes linter CLI commands and options from the command-line interface
- Updates build scripts to remove
--skip-lint
flags since linting is no longer included
Reviewed Changes
Copilot reviewed 29 out of 37 changed files in this pull request and generated no comments.
Show a summary per file
File | Description |
---|---|
src/parsers/markdown.mjs | Removes linter parameter and linting call from createParser function |
src/linter/ | Complete removal of linter directory with all rules, reporters, context, and utilities |
package.json | Removes linter-specific dependencies (@actions/core, unist-util-find, unist-util-find-before) |
README.md | Updates documentation to remove lint command and related options |
scripts/vercel-build.sh | Removes --skip-lint flag from build script |
.github/workflows/generate.yml | Removes --skip-lint flag from CI workflow |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
eeb8ce3
to
1044123
Compare
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #415 +/- ##
==========================================
- Coverage 74.22% 71.77% -2.45%
==========================================
Files 118 96 -22
Lines 10994 9368 -1626
Branches 696 578 -118
==========================================
- Hits 8160 6724 -1436
+ Misses 2831 2642 -189
+ Partials 3 2 -1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Fixes: #328
Fixes: #350
Linting is being moved to a separate package,
@node-core/remark-lint
(As an alternative to this PR, we could also have this package depend on
remark-lint
, but I feel like it's easy enough for consumers to be responsible for that)Blocked by nodejs/nodejs.org#8057