Skip to content

Conversation

legendecas
Copy link
Member

Fixes #1511

@codecov-commenter
Copy link

codecov-commenter commented Aug 1, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 65.58%. Comparing base (6babc96) to head (e61c5ca).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1676   +/-   ##
=======================================
  Coverage   65.58%   65.58%           
=======================================
  Files           3        3           
  Lines        2185     2185           
  Branches      730      730           
=======================================
  Hits         1433     1433           
  Misses        165      165           
  Partials      587      587           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@KevinEady
Copy link
Contributor

I tested this branch in debug build of Node.js v22.17.0 and it indeed fixes the crash from #1511

@legendecas legendecas merged commit b65e01b into nodejs:main Aug 1, 2025
54 checks passed
@github-project-automation github-project-automation bot moved this from In Progress to Done in Node-API Team Project Aug 1, 2025
@legendecas legendecas deleted the ehs branch August 1, 2025 16:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

function_reference test failure when using Debug build of node v20.13.1
4 participants