ci: tweak failure patterns, add GitFailure (#273)

Author: joyeecheung

lib/ci/ci_failure_parser.js

@@ -31,9 +31,11 @@ const BUILD_FAILURE = 'BUILD_FAILURE';
 const JS_TEST_FAILURE = 'JS_TEST_FAILURE';
 const CC_TEST_FAILURE = 'CC_TEST_FAILURE';
 const JENKINS_FAILURE = 'JENKINS_FAILURE';
+const GIT_FAILURE = 'GIT_FAILURE';
 
 const FAILURE_TYPES = {
-  BUILD_FAILURE, JS_TEST_FAILURE, CC_TEST_FAILURE, JENKINS_FAILURE
+  BUILD_FAILURE, JS_TEST_FAILURE, CC_TEST_FAILURE,
+  JENKINS_FAILURE, GIT_FAILURE
 };
 
 class CIResult {
@@ -83,14 +85,22 @@ class JenkinsFailure extends CIResult {
   }
 }
 
-function buildFailureMatcher(patterns, ctx, text) {
+// Usually need a fix to the build scripts or in workers
+class GitFailure extends CIResult {
+  constructor(ctx, reason) {
+    super(ctx, reason);
+    this.type = GIT_FAILURE;
+  }
+}
+
+function failureMatcher(Failure, patterns, ctx, text) {
   for (const pattern of patterns) {
     const matches = text.match(pattern.pattern);
     if (!matches) {
       continue;
     }
-    const reason = pickContext(matches, text, pattern.context);
-    return [new BuildFailure(ctx, reason)];
+    const reason = pickContext(matches, text, pattern.context).trim();
+    return [new Failure(ctx, reason)];
   }
   return null;
 }
@@ -114,52 +124,52 @@ const FAILURE_FILTERS = [{
   }
 }, {
   filter(ctx, text) {
-    const pattern = /\[ {2}FAILED {2}\].+/g;
-    const matches = text.match(pattern);
-    if (!matches) {
-      return null;
-    }
-    const reason = pickContext(matches, text, {
-      index: 0, contextBefore: 5, contextAfter: 0
-    });
-    return [new CCTestFailure(ctx, reason)];
+    const patterns = [{
+      pattern: /\[ {2}FAILED {2}\].+/g,
+      context: { index: 0, contextBefore: 5, contextAfter: 0 }
+    }];
+    return failureMatcher(CCTestFailure, patterns, ctx, text);
   }
 }, {
   // VS compilation error
   filter(ctx, text) {
-    const pattern = /error C\d+:/mg;
-    const matches = text.match(pattern);
-    if (!matches) {
-      return null;
-    }
-    const reason = pickContext(matches, text, {
-      index: 0, contextBefore: 0, contextAfter: 5
-    });
-    return [new BuildFailure(ctx, reason)];
+    const patterns = [{
+      pattern: /error C\d+:/mg,
+      context: { index: 0, contextBefore: 0, contextAfter: 5 }
+    }];
+    return failureMatcher(BuildFailure, patterns, ctx, text);
   }
 }, {
   filter(ctx, text) {
-    const pattern = /java\.io\.IOException.+/g;
-    const matches = text.match(pattern);
-    if (!matches) {
-      return null;
-    }
-    const reason = pickContext(matches, text, {
-      index: -1, contextBefore: 0, contextAfter: 5
-    });
-    return [new JenkinsFailure(ctx, reason)];
+    const patterns = [{
+      pattern: /java\.io\.IOException.+/g,
+      context: { index: -1, contextBefore: 0, contextAfter: 5 }
+    }, {
+      pattern: /Build timed out/g,
+      context: { index: 0, contextBefore: 0, contextAfter: 1 }
+    }];
+    return failureMatcher(JenkinsFailure, patterns, ctx, text);
   }
 }, {
   filter(ctx, text) {
-    const pattern = /hudson\.plugins\.git\.GitException+/g;
+    const pattern =
+      /Changes not staged for commit:[\s\S]+no changes added to commit/mg;
     const matches = text.match(pattern);
     if (!matches) {
       return null;
     }
-    const reason = pickContext(matches, text, {
-      index: 0, contextBefore: 2, contextAfter: 5
-    }).trim();
-    return [new JenkinsFailure(ctx, reason)];
+    return new GitFailure(ctx, matches[0]);
+  }
+}, {
+  filter(ctx, text) {
+    const patterns = [{
+      pattern: /hudson\.plugins\.git\.GitException+/g,
+      context: { index: 0, contextBefore: 2, contextAfter: 5 }
+    }, {
+      pattern: /Cannot rebase: .+/g,
+      context: { index: 0, contextBefore: 0, contextAfter: 1 }
+    }];
+    return failureMatcher(GitFailure, patterns, ctx, text);
   }
 }, {
   filter(ctx, text) {
@@ -172,7 +182,7 @@ const FAILURE_FILTERS = [{
       pattern: /Error: .+/g,
       context: { index: 0, contextBefore: 0, contextAfter: 5 }
     }];
-    return buildFailureMatcher(patterns, ctx, text);
+    return failureMatcher(BuildFailure, patterns, ctx, text);
   }
 }, {
   filter(ctx, text) {
@@ -187,6 +197,9 @@ const FAILURE_FILTERS = [{
 }, {
   filter(ctx, text) {
     const patterns = [{
+      pattern: /bash: line /g,
+      context: { index: 0, contextBefore: 0, contextAfter: 1 }
+    }, {
       pattern: /FATAL: .+/g,
       context: { index: -1, contextBefore: 0, contextAfter: 5 }
     }, {
@@ -204,17 +217,8 @@ const FAILURE_FILTERS = [{
     }, {
       pattern: /warning: failed .+/g,
       context: { index: 0, contextBefore: 0, contextAfter: 3 }
-    }, {
-      pattern: /Build timed out/g,
-      context: { index: 0, contextBefore: 0, contextAfter: 1 }
-    }, {
-      pattern: /bash: line /g,
-      context: { index: 0, contextBefore: 0, contextAfter: 1 }
-    }, {
-      pattern: /Cannot rebase: You have unstaged changes/g,
-      context: { index: 0, contextBefore: 0, contextAfter: 1 }
     }];
-    return buildFailureMatcher(patterns, ctx, text);
+    return failureMatcher(BuildFailure, patterns, ctx, text);
   }
 }];
 
@@ -242,7 +246,8 @@ CIFailureParser.FAILURE_CONSTRUCTORS = {
   BUILD_FAILURE: BuildFailure,
   JENKINS_FAILURE: JenkinsFailure,
   JS_TEST_FAILURE: JSTestFailure,
-  CC_TEST_FAILURE: CCTestFailure
+  CC_TEST_FAILURE: CCTestFailure,
+  GIT_FAILURE: GitFailure
 };
 CIFailureParser.CIResult = CIResult;
 module.exports = CIFailureParser;

test/fixtures/jenkins/jenkins-failure-1/expected.json renamed to test/fixtures/jenkins/git-failure-1/expected.json

@@ -2,7 +2,7 @@
   {
     "source": "https://github.com/nodejs/node/pull/21273/",
     "upstream": "https://ci.nodejs.org/job/node-test-pull-request/15449/",
-    "type": "JENKINS_FAILURE",
+    "type": "GIT_FAILURE",
     "url": "https://ci.nodejs.org/job/node-test-commit-linuxone/label=rhel72-s390x/2220/console",
     "reason": "ERROR: Error fetching remote repo 'origin'\nhudson.plugins.git.GitException: Failed to fetch from [email protected]:nodejs/node.git\n\tat hudson.plugins.git.GitSCM.fetchFrom(GitSCM.java:889)\n\tat hudson.plugins.git.GitSCM.retrieveChanges(GitSCM.java:1146)\n\tat hudson.plugins.git.GitSCM.checkout(GitSCM.java:1177)\n\tat hudson.scm.SCM.checkout(SCM.java:504)",
     "highlight": 0,

test/fixtures/jenkins/jenkins-failure-1/expected.md renamed to test/fixtures/jenkins/git-failure-1/expected.md

@@ -0,0 +1,90 @@
+19:15:49 Started by upstream project "node-test-commit-linuxone" build number 3915
+19:15:49 originally caused by:
+19:15:49  Started by upstream project "node-test-commit" build number 20504
+19:15:49  originally caused by:
+19:15:49   Started by upstream project "node-test-pull-request" build number 16429
+19:15:49   originally caused by:
+19:15:49    Started by user mscdex
+19:15:49 [EnvInject] - Loading node environment variables.
+19:15:50 Building remotely on test-linuxonecc-rhel72-s390x-3 (rhel72-s390x v8test2) in workspace /data/iojs/build/workspace/node-test-commit-linuxone/nodes/rhel72-s390x
+19:15:50  > git rev-parse --is-inside-work-tree # timeout=10
+19:15:50 Fetching changes from the remote Git repository
+19:15:50  > git config remote.origin.url [email protected]:nodejs/node.git # timeout=10
+19:15:50 Fetching upstream changes from [email protected]:nodejs/node.git
+19:15:50  > git --version # timeout=10
+19:15:50 using GIT_SSH to set credentials 
+19:15:50  > git fetch --no-tags --progress [email protected]:nodejs/node.git +refs/heads/*:refs/remotes/origin/* +refs/pull/22273/head:refs/remotes/origin/_jenkins_local_branch # timeout=20
+19:15:54 Checking out Revision f6438c66a065bc2a43f24f636e46e688ae0f4eee (refs/remotes/origin/_jenkins_local_branch)
+19:15:54  > git config core.sparsecheckout # timeout=10
+19:15:54  > git checkout -f f6438c66a065bc2a43f24f636e46e688ae0f4eee
+19:15:54 Commit message: "fixup: remove branch entirely instead of asserting"
+19:15:54  > git rev-list --no-walk 4757c91dc4e270aed9add3a65d3aa32a7b24a479 # timeout=10
+19:15:55 Cleaning workspace
+19:15:55  > git rev-parse --verify HEAD # timeout=10
+19:15:55 Resetting working tree
+19:15:55  > git reset --hard # timeout=10
+19:15:55  > git clean -fdx # timeout=10
+19:15:56 Exporting environment variable NODEJS_VERSION with Node.js version '11.0.0'
+19:15:56 Exporting environment variable NODEJS_MAJOR_VERSION with Node.js major version '11'
+19:15:56 Exporting parameter NODEJS_VERSION with Node.js version '11.0.0'
+19:15:56 Exporting parameter NODEJS_MAJOR_VERSION with Node.js major version '11'
+19:15:56 [rhel72-s390x] $ /bin/sh -xe /tmp/jenkins7325057057705257195.sh
+19:15:56 + curl https://raw.githubusercontent.com/nodejs/build/master/jenkins/scripts/node-test-commit-pre.sh
+19:15:56 + bash -ex -s before
+19:15:56   % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
+19:15:56                                  Dload  Upload   Total   Spent    Left  Speed
+19:15:57 
+  0     0    0     0    0     0      0      0 --:--:-- --:--:-- --:--:--     0
+100  1165  100  1165    0     0   4034      0 --:--:-- --:--:-- --:--:--  4045
+19:15:57 + git --version
+19:15:57 git version 1.8.3.1
+19:15:57 + git config --replace-all user.name Dummy
+19:15:57 + git config --replace-all user.email [email protected]
+19:15:57 + git config user.name
+19:15:57 Dummy
+19:15:57 + git config user.email
+19:15:57 [email protected]
+19:15:57 + echo
+19:15:57 
+19:15:57 + echo
+19:15:57 
+19:15:57 + git rebase --abort
+19:15:57 No rebase in progress?
+19:15:57 + true
+19:15:57 + git checkout -f refs/remotes/origin/_jenkins_local_branch
+19:15:57 HEAD is now at f6438c6... fixup: remove branch entirely instead of asserting
+19:15:57 + git config user.name
+19:15:57 Dummy
+19:15:57 + git config user.email
+19:15:57 [email protected]
+19:15:57 + echo
+19:15:57 
+19:15:57 + echo
+19:15:57 
+19:15:57 + git status
+19:15:57 # HEAD detached at f6438c6
+19:15:57 # Changes not staged for commit:
+19:15:57 #   (use "git add <file>..." to update what will be committed)
+19:15:57 #   (use "git checkout -- <file>..." to discard changes in working directory)
+19:15:57 #
+19:15:57 #	modified:   deps/v8/third_party/jinja2/LICENSE
+19:15:57 #
+19:15:57 # Untracked files:
+19:15:57 #   (use "git add <file>..." to include in what will be committed)
+19:15:57 #
+19:15:57 #	build/
+19:15:57 no changes added to commit (use "git add" and/or "git commit -a")
+19:15:57 + git rev-parse HEAD
+19:15:57 f6438c66a065bc2a43f24f636e46e688ae0f4eee
+19:15:57 + git rev-parse 78584b64d88c0567c46e3cf7bae42aa73927df40
+19:15:57 78584b64d88c0567c46e3cf7bae42aa73927df40
+19:15:57 + '[' -n 78584b64d88c0567c46e3cf7bae42aa73927df40 ']'
+19:15:57 + git rebase --committer-date-is-author-date 78584b64d88c0567c46e3cf7bae42aa73927df40
+19:15:57 Cannot rebase: You have unstaged changes.
+19:15:58 Please commit or stash them.
+19:15:58 Build step 'Execute shell' marked build as failure
+19:15:58 Recording test results
+19:15:58 ERROR: Step ‘Publish JUnit test result report’ failed: No test report files were found. Configuration error?
+19:15:58 Sending e-mails to: [email protected] [email protected]
+19:16:00 Notifying upstream projects of job completion
+19:16:00 Finished: FAILURE

test/fixtures/jenkins/jenkins-failure-1/node-test-commit-19225.json renamed to test/fixtures/jenkins/git-failure-1/node-test-commit-19225.json

@@ -0,0 +1,7 @@
+{
+  "url": "https://ci.nodejs.org/job/node-test-commit-linuxone/nodes=rhel72-s390x/3915/console",
+  "builtOn": "test-linuxonecc-rhel72-s390x-3",
+  "reason": "Changes not staged for commit:\n19:15:57 #   (use \"git add <file>...\" to update what will be committed)\n19:15:57 #   (use \"git checkout -- <file>...\" to discard changes in working directory)\n19:15:57 #\n19:15:57 #\tmodified:   deps/v8/third_party/jinja2/LICENSE\n19:15:57 #\n19:15:57 # Untracked files:\n19:15:57 #   (use \"git add <file>...\" to include in what will be committed)\n19:15:57 #\n19:15:57 #\tbuild/\n19:15:57 no changes added to commit",
+  "highlight": 0,
+  "type": "GIT_FAILURE"
+}