-
Notifications
You must be signed in to change notification settings - Fork 119
chore: update release-please config #852
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
- Use new repository for the action - Use nodejs-github-bot's PAT
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We could also set explicitly permissions: contents: read
since that's the only needed permission required from now on IIUC
According to the docs, it needs write permission: https://github.com/googleapis/release-please-action#workflow-permissions |
Setting |
I see. Updated, thanks! |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #852 +/- ##
==========================================
- Coverage 83.08% 83.00% -0.09%
==========================================
Files 37 37
Lines 4251 4266 +15
==========================================
+ Hits 3532 3541 +9
- Misses 719 725 +6 ☔ View full report in Codecov by Sentry. |
https://github.com/nodejs/node-core-utils/actions/runs/10655797184/job/29533746319 |
|
I might have given the wrong permission. Will check when I'm on my computer unless someone else does it first |
I forgot to give write access to the bot in https://github.com/nodejs/node-core-utils/settings/access. Now it's done. |
Uh oh!
There was an error while loading. Please reload this page.