Skip to content

Conversation

targos
Copy link
Member

@targos targos commented Sep 1, 2024

  • Use new repository for the action
  • Use nodejs-github-bot's PAT
  • Set minimal permissions for the default token

- Use new repository for the action
- Use nodejs-github-bot's PAT
@targos targos linked an issue Sep 1, 2024 that may be closed by this pull request
Copy link
Contributor

@aduh95 aduh95 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We could also set explicitly permissions: contents: read since that's the only needed permission required from now on IIUC

@targos
Copy link
Member Author

targos commented Sep 1, 2024

According to the docs, it needs write permission: https://github.com/googleapis/release-please-action#workflow-permissions

@aduh95
Copy link
Contributor

aduh95 commented Sep 1, 2024

According to the docs, it needs write permission: https://github.com/googleapis/release-please-action#workflow-permissions

Setting permissions: contents: read only affects permission of the GITHUB_TOKEN, which is only used by actions/checkout after this PR. The required permissions for googleapis/release-please-action are irrelevant, because it uses a different token IIUC.

@targos
Copy link
Member Author

targos commented Sep 1, 2024

I see. Updated, thanks!

Copy link

codecov bot commented Sep 1, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 83.00%. Comparing base (e3e19b3) to head (7aa5220).
Report is 26 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #852      +/-   ##
==========================================
- Coverage   83.08%   83.00%   -0.09%     
==========================================
  Files          37       37              
  Lines        4251     4266      +15     
==========================================
+ Hits         3532     3541       +9     
- Misses        719      725       +6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@aduh95 aduh95 merged commit b4842d3 into main Sep 1, 2024
9 of 11 checks passed
@aduh95 aduh95 deleted the release-token branch September 1, 2024 16:57
@aduh95
Copy link
Contributor

aduh95 commented Sep 1, 2024

RequestError [HttpError]: Error creating Pull Request: Resource not accessible by personal access token 🤔

https://github.com/nodejs/node-core-utils/actions/runs/10655797184/job/29533746319

@aduh95
Copy link
Contributor

aduh95 commented Sep 1, 2024

'x-accepted-github-permissions': 'contents=write; contents=write,workflows=write', I suppose that's lacking pull-request=write? Also, I don't think we need workflows=write

@targos
Copy link
Member Author

targos commented Sep 1, 2024

I might have given the wrong permission. Will check when I'm on my computer unless someone else does it first

@targos
Copy link
Member Author

targos commented Sep 1, 2024

@targos
Copy link
Member Author

targos commented Sep 1, 2024

I forgot to give write access to the bot in https://github.com/nodejs/node-core-utils/settings/access. Now it's done.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

release-please is broken
2 participants