Skip to content

fix(v8): mark boolean CLI options as such #861

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 4, 2024
Merged

fix(v8): mark boolean CLI options as such #861

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7be1179
fix(v8): mark boolean CLI options as such
targos Sep 30, 2024
f79fd3e
Update components/git/v8.js
targos Sep 30, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion components/git/v8.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,7 @@ export function builder(yargs) {
default: 'lkgr'
});
yargs.option('version-bump', {
type: 'boolean',
describe: 'Bump the NODE_MODULE_VERSION constant',
default: true
});
Expand All @@ -39,10 +40,12 @@ export function builder(yargs) {
builder: (yargs) => {
yargs
.option('bump', {
type: 'boolean',
describe: 'Bump V8 embedder version number or patch version',
default: true
})
.option('squash', {
type: 'boolean',
describe:
'If multiple commits are backported, squash them into one',
default: false
Expand All @@ -62,8 +65,8 @@ export function builder(yargs) {
describe: 'Directory of an existing V8 clone'
})
.option('verbose', {
type: 'boolean',
describe: 'Enable verbose output',
boolean: true,
default: false
});
}
Expand Down
Loading