Skip to content

update: fix default answers in release --prepare #864

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 2, 2024
Merged

update: fix default answers in release --prepare #864

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 2 additions & 8 deletions lib/prepare_release.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -253,9 +253,6 @@ export default class ReleasePreparation extends Session {
await this.updateMajorChangelog();
cli.stopSpinner(`Updated CHANGELOG_V${versionComponents.major}.md`);

await cli.prompt('Finished editing the changelogs?',
{ defaultAnswer: false });

// Create release commit.
const shouldCreateReleaseCommit = await cli.prompt(
'Create release commit?');
Expand All @@ -272,9 +269,7 @@ export default class ReleasePreparation extends Session {
cli.warn(`Please manually edit commit ${lastCommitSha} by running ` +
'`git commit --amend` before proceeding.');

await cli.prompt(
'Finished editing the release commit?',
{ defaultAnswer: false });
await cli.prompt('Finished editing the release commit?');
}

cli.separator();
Expand Down Expand Up @@ -625,8 +620,7 @@ export default class ReleasePreparation extends Session {
]);

cli.log(`${messageTitle}\n\n${messageBody.join('')}`);
const useMessage = await cli.prompt(
'Continue with this commit message?', { defaultAnswer: false });
const useMessage = await cli.prompt('Continue with this commit message?');
return useMessage;
}

Expand Down
Loading