Skip to content

fix: handle UNKNOWN status and lint fix #892

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 20, 2025
Merged

fix: handle UNKNOWN status and lint fix #892

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 2 additions & 3 deletions lib/prepare_release.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,7 @@ export default class ReleasePreparation extends Session {
const { cli } = this;

cli.warn(`PR#${pr.number} - ${pr.title} is not 'MERGEABLE'.
So, it will be skipped. Status: ${pr.mergeable}`);
Status: ${pr.mergeable}`);
}

async getOpenPRs(filterLabels) {
Expand All @@ -66,7 +66,6 @@ export default class ReleasePreparation extends Session {
for (const pr of prs) {
if (pr.mergeable !== 'MERGEABLE') {
this.warnForNonMergeablePR(pr);
continue;
}
const cp = new CherryPick(pr.number, this.dir, cli, {
owner: this.owner,
Expand Down Expand Up @@ -486,7 +485,7 @@ export default class ReleasePreparation extends Session {
let releaseHeader = `## ${date}, Version ${newVersion}` +
` ${releaseInfo}, @${username}\n`;
if (isSecurityRelease) {
releaseHeader += '\nThis is a security release.';
releaseHeader += '\nThis is a security release.\n';
}

const topHeader =
Expand Down
Loading