Skip to content

fix: fix post-release dependency updates generation #896

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 19, 2025
Merged

fix: fix post-release dependency updates generation #896

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 2 additions & 6 deletions lib/security_blog.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -250,12 +250,8 @@ export default class SecurityBlog extends SecurityRelease {
if (Object.keys(dependencyUpdates).length === 0) return '';
let template = '\nThis security release includes the following dependency' +
' updates to address public vulnerabilities:\n';
for (const dependencyUpdate of Object.values(dependencyUpdates)) {
for (const dependency of dependencyUpdate) {
const title = dependency.title.substring(dependency.title.indexOf(':') + ':'.length).trim();
template += `- ${title}\
on ${dependency.affectedVersions.join(', ')}\n`;
}
for (const [dependency, { versions, affectedVersions }] of Object.entries(dependencyUpdates)) {
template += `- ${dependency} (${versions.join(', ')}) on ${affectedVersions.join(', ')}\n`;
}
return template;
}
Expand Down
Loading