Skip to content

fix(ncu-ci): fetch commits instead of PR metadata #915

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 1, 2025
Merged

fix(ncu-ci): fetch commits instead of PR metadata #915

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion lib/ci/run_ci.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@ export class RunPRJob {
this.prData = new PRData({ prid, owner, repo }, cli, request);
this.certifySafe =
certifySafe ||
Promise.all([this.prData.getReviews(), this.prData.getPR()]).then(() =>
Promise.all([this.prData.getReviews(), this.prData.getCommits()]).then(() =>
(this.certifySafe = new PRChecker(cli, this.prData, request, {}).getApprovedTipOfHead())
);
}
Expand Down
2 changes: 1 addition & 1 deletion lib/pr_checker.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -531,7 +531,7 @@
const { maxCommits } = argv;

if (commits.length === 0) {
cli.warn('No commits found');
cli.warn('No commits detected');

Check warning on line 534 in lib/pr_checker.js

View check run for this annotation

Codecov / codecov/patch

lib/pr_checker.js#L534 

Added line #L534 was not covered by tests
return false;
}

Expand Down
Loading