Skip to content

fix(ncu-ci): pass COMMIT_SHA_CHECK to V8 CI #928

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 22, 2025
Merged

fix(ncu-ci): pass COMMIT_SHA_CHECK to V8 CI #928

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
44806a2
fix(ncu-ci): pass `COMMIT_SHA_CHECK` to V8 CI
richardlau May 9, 2025
031133c
fixup! fix(ncu-ci): pass `COMMIT_SHA_CHECK` to V8 CI
richardlau May 9, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion lib/ci/run_ci.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -62,7 +62,8 @@
parameter: [
{ name: 'GITHUB_ORG', value: this.owner },
{ name: 'REPO_NAME', value: this.repo },
{ name: 'GIT_REMOTE_REF', value: `refs/pull/${this.prid}/head` }
{ name: 'GIT_REMOTE_REF', value: `refs/pull/${this.prid}/head` },
{ name: 'COMMIT_SHA_CHECK', value: this.certifySafe }

Check warning on line 66 in lib/ci/run_ci.js

View check run for this annotation

Codecov / codecov/patch

lib/ci/run_ci.js#L65-L66 

Added lines #L65 - L66 were not covered by tests
]
}));
return payload;
Expand Down
Loading