Skip to content

Commit 34def51

Browse files
committed
build: skip build-ci on run-ci
When run `make run-ci` with CONFIG_FLAGS only set in prior `make build-ci`, `make run-ci` will try to rebuild everything, instead of re-use the built result from prior `make build-ci`.
1 parent 05f8772 commit 34def51

File tree

2 files changed

+2
-1
lines changed

2 files changed

+2
-1
lines changed

.github/workflows/test-shared.yml

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -194,5 +194,6 @@ jobs:
194194
--arg benchmarkTools '[]' \
195195
${{ endsWith(matrix.system, '-darwin') && '--arg withAmaro false --arg withSQLite false --arg extraConfigFlags ''["--without-inspector" "--without-node-options"]'' \' || '\' }}
196196
--run '
197+
make -C "$TAR_DIR" build-ci -j4 V=1
197198
make -C "$TAR_DIR" run-ci -j4 V=1 TEST_CI_ARGS="-p actions --measure-flakiness 9 --skip-tests=$CI_SKIP_TESTS"
198199
'

Makefile

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -638,7 +638,7 @@ build-ci: ## Build everything (CI).
638638
#
639639
# Using -j1 as the sub target in `test-ci` already have internal parallelism.
640640
# Refs: https://github.com/nodejs/node/pull/23733
641-
run-ci: build-ci ## Build and run all tests (CI).
641+
run-ci: ## Run all tests (CI).
642642
$(MAKE) test-ci -j1
643643

644644
.PHONY: test-release

0 commit comments

Comments
 (0)