Skip to content

Commit 58ca77f

Browse files
committed
sqlite: add sqlite property to async database
1 parent cc6263a commit 58ca77f

File tree

2 files changed

+15
-16
lines changed

2 files changed

+15
-16
lines changed

src/node_sqlite.cc

Lines changed: 7 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -3784,6 +3784,13 @@ inline void DefineDatabaseMethods(Isolate* isolate,
37843784
tmpl,
37853785
FIXED_ONE_BYTE_STRING(isolate, "isTransaction"),
37863786
Database::IsTransactionGetter);
3787+
3788+
Local<String> sqlite_type_key = FIXED_ONE_BYTE_STRING(isolate, "sqlite-type");
3789+
Local<v8::Symbol> sqlite_type_symbol =
3790+
v8::Symbol::For(isolate, sqlite_type_key);
3791+
Local<String> database_sync_string =
3792+
FIXED_ONE_BYTE_STRING(isolate, "node:sqlite");
3793+
tmpl->InstanceTemplate()->Set(sqlite_type_symbol, database_sync_string);
37873794
}
37883795

37893796
static void Initialize(Local<Object> target,
@@ -3805,14 +3812,6 @@ static void Initialize(Local<Object> target,
38053812
DefineStatementFunctionTemplates(env);
38063813
DefineDatabaseMethods(isolate, db_tmpl);
38073814
DefineDatabaseMethods(isolate, db_async_tmpl);
3808-
3809-
Local<String> sqlite_type_key = FIXED_ONE_BYTE_STRING(isolate, "sqlite-type");
3810-
Local<v8::Symbol> sqlite_type_symbol =
3811-
v8::Symbol::For(isolate, sqlite_type_key);
3812-
Local<String> database_sync_string =
3813-
FIXED_ONE_BYTE_STRING(isolate, "node:sqlite");
3814-
db_tmpl->InstanceTemplate()->Set(sqlite_type_symbol, database_sync_string);
3815-
38163815
SetConstructorFunction(context, target, "DatabaseSync", db_tmpl);
38173816
SetConstructorFunction(context,
38183817
target,

test/parallel/test-sqlite-database-async.mjs

Lines changed: 8 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -276,14 +276,14 @@ suite('Database() constructor', () => {
276276
);
277277
});
278278

279-
// test('has sqlite-type symbol property', (t) => {
280-
// const dbPath = nextDb();
281-
// const db = new Database(dbPath);
282-
// t.after(() => { db.close(); });
283-
284-
// const sqliteTypeSymbol = Symbol.for('sqlite-type');
285-
// t.assert.strictEqual(db[sqliteTypeSymbol], 'node:sqlite');
286-
// });
279+
test('has sqlite-type symbol property', (t) => {
280+
const dbPath = nextDb();
281+
const db = new Database(dbPath);
282+
t.after(() => { db.close(); });
283+
284+
const sqliteTypeSymbol = Symbol.for('sqlite-type');
285+
t.assert.strictEqual(db[sqliteTypeSymbol], 'node:sqlite');
286+
});
287287
});
288288

289289
suite('Database.prototype.open()', () => {

0 commit comments

Comments
 (0)