Skip to content

Commit 7dd49d7

Browse files
committed
test: spin longer for sequential/test-worker-prof
On Windows with V8 14.1, we are just below the current threshold. PR-URL: #59805 Reviewed-By: Filip Skokan <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: Colin Ihrig <[email protected]>
1 parent faba50d commit 7dd49d7

File tree

1 file changed

+2
-2
lines changed

1 file changed

+2
-2
lines changed

test/sequential/test-worker-prof.js

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,7 @@ if (process.argv[2] === 'child') {
1919
const w = new Worker(`
2020
const { parentPort, workerData } = require('worker_threads');
2121
22-
const SPIN_MS = 1000;
22+
const SPIN_MS = 1500;
2323
const start = Date.now();
2424
parentPort.on('message', (data) => {
2525
if (Date.now() - start < SPIN_MS) {
@@ -76,7 +76,7 @@ if (process.argv[2] === 'child') {
7676
console.log('parent ticks', parentTicks.length);
7777
// When not tracking Worker threads, only 1 or 2 ticks would
7878
// have been recorded.
79-
// prof_sampling_interval is by default 1 millisecond. A higher NODE_TEST_SPIN_MS
79+
// prof_sampling_interval is by default 1 millisecond. A higher SPIN_MS
8080
// should result in more ticks, while 15 should be safe on most machines.
8181
assert(workerTicks.length > 15, `worker ticks <= 15:\n${workerTicks.join('\n')}`);
8282
assert(parentTicks.length > 15, `parent ticks <= 15:\n${parentTicks.join('\n')}`);

0 commit comments

Comments
 (0)