Skip to content

Commit 8ed9534

Browse files
committed
deps: make V8 14.2 ABI-compatible with 14.1
- Revert adding `contextId` to `V8InspectorClient::consoleAPIMessage` function Refs: v8/v8@f4d337d
1 parent a96cb19 commit 8ed9534

File tree

4 files changed

+3
-13
lines changed

4 files changed

+3
-13
lines changed

deps/v8/include/v8-inspector.h

Lines changed: 0 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -288,21 +288,11 @@ class V8_EXPORT V8InspectorClient {
288288

289289
virtual void installAdditionalCommandLineAPI(v8::Local<v8::Context>,
290290
v8::Local<v8::Object>) {}
291-
// Deprecated. Use version with contextId.
292291
virtual void consoleAPIMessage(int contextGroupId,
293292
v8::Isolate::MessageErrorLevel level,
294293
const StringView& message,
295294
const StringView& url, unsigned lineNumber,
296295
unsigned columnNumber, V8StackTrace*) {}
297-
virtual void consoleAPIMessage(int contextGroupId, int contextId,
298-
v8::Isolate::MessageErrorLevel level,
299-
const StringView& message,
300-
const StringView& url, unsigned lineNumber,
301-
unsigned columnNumber,
302-
V8StackTrace* stackTrace) {
303-
consoleAPIMessage(contextGroupId, level, message, url, lineNumber,
304-
columnNumber, stackTrace);
305-
}
306296
virtual v8::MaybeLocal<v8::Value> memoryInfo(v8::Isolate*,
307297
v8::Local<v8::Context>) {
308298
return v8::MaybeLocal<v8::Value>();

deps/v8/src/inspector/v8-console-message.cc

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -493,7 +493,7 @@ std::unique_ptr<V8ConsoleMessage> V8ConsoleMessage::createForConsoleAPI(
493493

494494
if (type != ConsoleAPIType::kClear) {
495495
inspector->client()->consoleAPIMessage(
496-
groupId, contextId, clientLevel, toStringView(message->m_message),
496+
groupId, clientLevel, toStringView(message->m_message),
497497
toStringView(message->m_url), message->m_lineNumber,
498498
message->m_columnNumber, message->m_stackTrace.get());
499499
}

deps/v8/test/inspector/isolate-data.cc

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -565,7 +565,7 @@ void InspectorIsolateData::installAdditionalCommandLineAPI(
565565
}
566566

567567
void InspectorIsolateData::consoleAPIMessage(
568-
int contextGroupId, int contextId, v8::Isolate::MessageErrorLevel level,
568+
int contextGroupId, v8::Isolate::MessageErrorLevel level,
569569
const v8_inspector::StringView& message,
570570
const v8_inspector::StringView& url, unsigned lineNumber,
571571
unsigned columnNumber, v8_inspector::V8StackTrace* stack) {

deps/v8/test/inspector/isolate-data.h

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -132,7 +132,7 @@ class InspectorIsolateData : public v8_inspector::V8InspectorClient {
132132
void quitMessageLoopOnPause() override;
133133
void installAdditionalCommandLineAPI(v8::Local<v8::Context>,
134134
v8::Local<v8::Object>) override;
135-
void consoleAPIMessage(int contextGroupId, int contextId,
135+
void consoleAPIMessage(int contextGroupId,
136136
v8::Isolate::MessageErrorLevel level,
137137
const v8_inspector::StringView& message,
138138
const v8_inspector::StringView& url,

0 commit comments

Comments
 (0)