Skip to content

test_runner: support module detection in module mocks #53642

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 4, 2024
Merged

test_runner: support module detection in module mocks #53642

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion lib/internal/test_runner/mock/mock.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -513,7 +513,9 @@ class MockTracker {
mockSpecifier, caller, null,
);
debug('module mock, url = "%s", format = "%s", caller = "%s"', url, format, caller);
validateOneOf(format, 'format', kSupportedFormats);
if (format) { // Format is not yet known for ambiguous files when detection is enabled.
validateOneOf(format, 'format', kSupportedFormats);
}
const baseURL = URL.parse(url);

if (!baseURL) {
Expand Down
20 changes: 14 additions & 6 deletions lib/test/mock_loader.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -143,26 +143,34 @@ async function load(url, context, nextLoad) {
const baseURL = parsedURL ? parsedURL.href : url;
const mock = mocks.get(baseURL);

const original = await nextLoad(url, context);
debug('load hook, mock = %o', mock);
if (mock?.active !== true) {
return nextLoad(url);
return original;
}

// Treat builtins as commonjs because customization hooks do not allow a
// core module to be replaced.
const format = mock.format === 'builtin' ? 'commonjs' : mock.format;
// Also collapse 'commonjs-sync' and 'require-commonjs' to 'commonjs'.
const format = (
original.format === 'builtin' ||
original.format === 'commonjs-sync' ||
original.format === 'require-commonjs') ? 'commonjs' : original.format;

return {
const result = {
__proto__: null,
format,
shortCircuit: true,
source: await createSourceFromMock(mock),
source: await createSourceFromMock(mock, format),
};

debug('load hook finished, result = %o', result);
return result;
}

async function createSourceFromMock(mock) {
async function createSourceFromMock(mock, format) {
// Create mock implementation from provided exports.
const { exportNames, format, hasDefaultExport, url } = mock;
const { exportNames, hasDefaultExport, url } = mock;
const useESM = format === 'module';
const source = `${testImportSource(useESM)}
if (!$__test.mock._mockExports.has('${url}')) {
Expand Down