- 
          
- 
                Notifications
    You must be signed in to change notification settings 
- Fork 33.6k
2024-11-20, Version 23.3.0 (Current), @RafaelGSS #55921
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
          
     Merged
      
      
    
      
        
          +48,779
        
        
          −21,009
        
        
          
        
      
    
  
  
     Merged
                    Changes from 1 commit
      Commits
    
    
            Show all changes
          
          
            56 commits
          
        
        Select commit
          Hold shift + click to select a range
      
      1f2fcf1
              
                doc: add history entries for JSON modules stabilization
              
              
                aduh95 00e092b
              
                util: fix util.getCallSites plurality
              
              
                legendecas d4e7926
              
                util: add sourcemap support to getCallSites
              
              
                marco-ippolito 7814669
              
                tools: fix c-ares updater script for Node.js 18
              
              
                richardlau bbb8f59
              
                lib: use `Promise.withResolvers()` in timers
              
              
                anonrig e147935
              
                deps: update icu to 76.1
              
              
                nodejs-github-bot cfe28b1
              
                lib: remove unnecessary optional chaining
              
              
                gurgunday d1ad43e
              
                test: improve test coverage for `ServerResponse`
              
              
                juanarbol 5767b76
              
                doc: enforce strict policy to semver-major releases
              
              
                RafaelGSS e1b42e7
              
                test: add buffer to fs_permission tests
              
              
                RafaelGSS 1568733
              
                lib: prefer symbol to number in webidl `type` function
              
              
                aduh95 9862912
              
                assert: differentiate cases where `cause` is `undefined` or missing
              
              
                aduh95 e1f54e2
              
                test: ensure that test priority is not higher than current priority
              
              
                LiviaMedeiros 8576ca9
              
                doc: clarify removal of experimental API does not require a deprecation
              
              
                aduh95 db0d648
              
                fs: fix bufferSize option for opendir recursive
              
              
                Ethan-Arrowood 3a9733c
              
                util: do not mark experimental feature as deprecated
              
              
                aduh95 84c4747
              
                test: improve test coverage for child process message sending
              
              
                juanarbol ccb69bb
              
                src: add cli option to preserve env vars on dr
              
              
                RafaelGSS 16786a6
              
                src: improve `node:os` userInfo performance
              
              
                anonrig aa12de0
              
                doc: sort --report-exclude alphabetically
              
              
                RafaelGSS 419ea06
              
                tools: remove non-existent file from eslint config
              
              
                avivkeller 8111a76
              
                tools: make commit-queue check blocked label
              
              
                marco-ippolito 3cfacd3
              
                tools: fix exclude labels for commit-queue
              
              
                richardlau bba7323
              
                build: apply cpp linting and formatting to ncrypto
              
              
                avivkeller 7773567
              
                build: use glob for dependencies of out/Makefile
              
              
                richardlau df5ea1a
              
                doc: clarify triager role
              
              
                gireeshpunathil 472d55e
              
                build: implement node_use_amaro flag in GN build
              
              
                zcbenz 9aeb671
              
                doc: run license-builder
              
              
                github-actions[bot] 83ba688
              
                esm: fix import.meta.resolve crash
              
              
                marco-ippolito 9c99255
              
                permission: ignore internalModuleStat on module loading
              
              
                RafaelGSS c210335
              
                benchmark: add `test_runner/mock-fn`
              
              
                avivkeller e0db9ed
              
                deps: update c-ares to v1.34.3
              
              
                nodejs-github-bot 5a437c4
              
                report: fix network queries in getReport libuv with exclude-network
              
              
                Tofandel 770670c
              
                test: fix permission fixtures lint
              
              
                RafaelGSS 65ffb2c
              
                doc: update unflag info of `import.meta.resolve`
              
              
                skyclouds2001 c5afdaf
              
                doc: correct max-semi-space-size statement
              
              
                joebowbeer 11e1bdd
              
                module: tidy code string concat → string templates
              
              
                JakobJingleheimer e56265c
              
                doc: fix history info for `URL.prototype.toJSON`
              
              
                aduh95 787e51e
              
                doc: add notable-change mention to sec release
              
              
                RafaelGSS bdb6d12
              
                events: add hasEventListener util for validate
              
              
                sungpaks a831184
              
                doc: clarify UV_THREADPOOL_SIZE env var usage
              
              
                preveen-stack 1b863b9
              
                doc: add `-S` flag release preparation example
              
              
                aduh95 32e5bbc
              
                benchmark: add `test-reporters`
              
              
                avivkeller ec953bc
              
                doc: add `node:sqlite` to mandatory `node:` prefix list
              
              
                sapphi-red e0ef65b
              
                doc: remove non-working example
              
              
                aduh95 dc8aca3
              
                deps: update undici to 6.21.0
              
              
                nodejs-github-bot cad557e
              
                deps: update simdutf to 5.6.1
              
              
                nodejs-github-bot 58d7a6e
              
                Revert "src: migrate `String::Value` to `String::ValueView`"
              
              
                targos 49d5522
              
                src: use env strings to create sqlite results
              
              
                targos 034505e
              
                test_runner: error on mocking an already mocked date
              
              
                avivkeller d41cb49
              
                fs: prevent unwanted `dependencyOwners` removal
              
              
                Ceres6 e0c2225
              
                crypto: allow length=0 for HKDF and PBKDF2 in SubtleCrypto.deriveBits
              
              
                panva 44324aa
              
                tools: bump @eslint/plugin-kit from 0.2.0 to 0.2.3 in /tools/eslint
              
              
                dependabot[bot] bcbba72
              
                sqlite: add support for SQLite Session Extension
              
              
                louwers 693fda0
              
                lib: remove unused file `fetch_module`
              
              
                targos 72f82ad
              
                2024-11-20, Version 23.3.0 (Current)
              
              
                RafaelGSS File filter
Filter by extension
Conversations
          Failed to load comments.   
        
        
          
      Loading
        
  Jump to
        
          Jump to file
        
      
      
          Failed to load files.   
        
        
          
      Loading
        
  Diff view
Diff view
There are no files selected for viewing
  
    
      This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
      Learn more about bidirectional Unicode characters
    
  
  
    
              
  
    
      This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
      Learn more about bidirectional Unicode characters
    
  
  
    
              
              
  
    
      This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
      Learn more about bidirectional Unicode characters
    
  
  
    
              
              
  
    
      This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
      Learn more about bidirectional Unicode characters
    
  
  
    
              
  
    
      This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
      Learn more about bidirectional Unicode characters
    
  
  
    
              
  
    
      This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
      Learn more about bidirectional Unicode characters
    
  
  
    
              
              
  
    
      This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
      Learn more about bidirectional Unicode characters
    
  
  
    
              
              
      
      Oops, something went wrong.
        
    
  
  Add this suggestion to a batch that can be applied as a single commit.
  This suggestion is invalid because no changes were made to the code.
  Suggestions cannot be applied while the pull request is closed.
  Suggestions cannot be applied while viewing a subset of changes.
  Only one suggestion per line can be applied in a batch.
  Add this suggestion to a batch that can be applied as a single commit.
  Applying suggestions on deleted lines is not supported.
  You must change the existing code in this line in order to create a valid suggestion.
  Outdated suggestions cannot be applied.
  This suggestion has been applied or marked resolved.
  Suggestions cannot be applied from pending reviews.
  Suggestions cannot be applied on multi-line comments.
  Suggestions cannot be applied while the pull request is queued to merge.
  Suggestion cannot be applied right now. Please check back later.
  
    
  
    
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
When working on the blog post, IMO it would be useful to amend this to say "diagnostic report" instead of "dr"
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I agree, but I also think that we should not accept "dr" in the commit message in the first place.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I wrote it to not exceed the commit message length.