Skip to content

[v22.x backport] src: add cli option to exclude env vars on dr #56055

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Dec 10, 2024
Merged

[v22.x backport] src: add cli option to exclude env vars on dr #56055

merged 3 commits into from
Dec 10, 2024

Conversation

@RafaelGSS
Copy link
Member

PR-URL: #55697
Reviewed-By: James M Snell [email protected]
Reviewed-By: Richard Lau [email protected]

@nodejs-github-bot nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. lib / src Issues and PRs related to general changes in the lib or src directory. needs-ci PRs that need a full CI run. v22.x Issues that can be reproduced on v22.x or PRs targeting the v22.x-staging branch. labels Nov 28, 2024
@RafaelGSS RafaelGSS added the request-ci Add this label to start a Jenkins CI on a PR. label Nov 29, 2024
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Nov 29, 2024
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/63775/

@richardlau
Copy link
Member

Since #55788 also didn't backport to v22.x-staging cleanly (because #55697, which this PR backports, needs to land first), perhaps it should also be part of this backport PR as a second commit?

@RafaelGSS RafaelGSS added the request-ci Add this label to start a Jenkins CI on a PR. label Dec 3, 2024
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Dec 3, 2024
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/63854/

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/63870/

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/63874/

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/63876/

@RafaelGSS RafaelGSS added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. commit-queue-rebase Add this label to allow the Commit Queue to land a PR in several commits. labels Dec 6, 2024
@aduh95
Copy link
Contributor

aduh95 commented Dec 6, 2024

Can you please add #56130 to this backport PR so the correct version is reported for Version 4 section?

@RafaelGSS RafaelGSS added the request-ci Add this label to start a Jenkins CI on a PR. label Dec 7, 2024
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Dec 7, 2024
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/63935/

RafaelGSS and others added 3 commits December 10, 2024 22:15
@RafaelGSS @aduh95
src: add cli option to preserve env vars on dr
0aee9af 
PR-URL: nodejs#55697
Backport-PR-URL: nodejs#56055
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
@RafaelGSS @aduh95
doc: sort --report-exclude alphabetically
803cc3b 
PR-URL: nodejs#55788
Backport-PR-URL: nodejs#56055
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Ulises Gascón <[email protected]>
PR-URL: nodejs#55697
@legendecas @aduh95
doc: add report version and history section
ba63702 
PR-URL: nodejs#56130
Backport-PR-URL: nodejs#56055
Refs: nodejs#56068
Reviewed-By: Gireesh Punathil <[email protected]>
Reviewed-By: Rafael Gonzaga <[email protected]>
PR-URL: nodejs#55697
@aduh95 aduh95 force-pushed the backport-55697-to-v22 branch from 96751a3 to ba63702 Compare December 10, 2024 21:25
@aduh95 aduh95 merged commit ba63702 into nodejs:v22.x-staging Dec 10, 2024
18 of 20 checks passed
@aduh95
Copy link
Contributor

aduh95 commented Dec 10, 2024

Landed in 4f85047...ba63702

ruyadorno pushed a commit that referenced this pull request Jan 5, 2025
@RafaelGSS @ruyadorno
src: add cli option to preserve env vars on dr
2e3ca1b 
PR-URL: #55697
Backport-PR-URL: #56055
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
ruyadorno pushed a commit that referenced this pull request Jan 5, 2025
@RafaelGSS @ruyadorno
doc: sort --report-exclude alphabetically
8cb3c20 
PR-URL: #55788
Backport-PR-URL: #56055
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Ulises Gascón <[email protected]>
PR-URL: #55697
ruyadorno pushed a commit that referenced this pull request Jan 5, 2025
@legendecas @ruyadorno
doc: add report version and history section
5263086 
PR-URL: #56130
Backport-PR-URL: #56055
Refs: #56068
Reviewed-By: Gireesh Punathil <[email protected]>
Reviewed-By: Rafael Gonzaga <[email protected]>
PR-URL: #55697
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

author ready PRs that have at least one approval, no pending requests for changes, and a CI started. c++ Issues and PRs that require attention from people who are familiar with C++. commit-queue-rebase Add this label to allow the Commit Queue to land a PR in several commits. lib / src Issues and PRs related to general changes in the lib or src directory. needs-ci PRs that need a full CI run. v22.x Issues that can be reproduced on v22.x or PRs targeting the v22.x-staging branch.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@RafaelGSS @nodejs-github-bot @richardlau @aduh95 @legendecas