Skip to content

module: fix jsdoc for format parameter in cjs/loader #56501

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
aduh95 merged 4 commits into from
Jan 15, 2025
Merged

module: fix jsdoc for format parameter in cjs/loader #56501

Changes from 3 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
5b69699
module: fix jsdoc for `format` parameter in cjs/loader
pacexy Jan 7, 2025
c277f3f
extract `ModuleFormat` type
pacexy Jan 7, 2025
f83ea63
Revert "extract `ModuleFormat` type"
pacexy Jan 13, 2025
fb57c7d
fix lint
pacexy Jan 14, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 1 addition & 3 deletions lib/internal/modules/cjs/loader.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1682,9 +1682,7 @@
* `exports`) to the file. Returns exception, if any.
* @param {string} content The source code of the module
* @param {string} filename The file path of the module
* @param {
* 'module'|'commonjs'|'commonjs-typescript'|'module-typescript'
* } format Intended format of the module.
* @param {'module'|'commonjs'|'commonjs-typescript'|'module-typescript'|'typescript'} format Intended format of the module.

Check failure on line 1685 in lib/internal/modules/cjs/loader.js

View workflow job for this annotation

GitHub Actions / lint-js-and-md 

This line has a length of 124. Maximum allowed is 120
*/
Module.prototype._compile = function(content, filename, format) {
if (format === 'commonjs-typescript' || format === 'module-typescript' || format === 'typescript') {
Expand Down
Loading