assert: make comparisons file more performant#57088
Closed
puskin wants to merge 1 commit intonodejs:mainfrom
Closed
assert: make comparisons file more performant#57088puskin wants to merge 1 commit intonodejs:mainfrom
puskin wants to merge 1 commit intonodejs:mainfrom
Conversation
4caa491 to
5edea40
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #57088 +/- ##
==========================================
- Coverage 89.09% 89.09% -0.01%
==========================================
Files 665 665
Lines 193249 193259 +10
Branches 37231 37224 -7
==========================================
+ Hits 172175 172178 +3
- Misses 13802 13812 +10
+ Partials 7272 7269 -3
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As part of my ongoing review of the
assertcodebase, I started examining thecomparisons.jsfile and optimizing some straightforward code that could be further refined for better performance.Here are the benchmark results for the
assert/deepequal-simple-array-and-set.jsfile:a performance improvement of 25-38% can be noticed in the sets tests