- 
          
- 
                Notifications
    You must be signed in to change notification settings 
- Fork 33.6k
[help wanted] deps: update V8 to 13.4 #57114
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
          
     Closed
      
      
    
  
     Closed
                    Changes from 1 commit
      Commits
    
    
            Show all changes
          
          
            37 commits
          
        
        Select commit
          Hold shift + click to select a range
      
      44cccbe
              
                deps: update V8 to 13.4.114.21
              
              
                targos 42f6adc
              
                build: reset embedder string to "-node.0"
              
              
                targos f3f4d5a
              
                src: update NODE_MODULE_VERSION to 136
              
              
                targos 54c8717
              
                deps: always define V8_EXPORT_PRIVATE as no-op
              
              
                targos 46d8aa0
              
                deps: disable V8 concurrent sparkplug compilation
              
              
                targos 1da6497
              
                deps: patch V8 to avoid duplicated zlib symbol
              
              
                targos 61b27b4
              
                deps: patch V8 to support compilation with MSVC
              
              
                StefanStojanovic 17d1f7b
              
                deps: fix FP16 bitcasts.h
              
              
                StefanStojanovic a5c5ae3
              
                deps: always define V8_NODISCARD as no-op
              
              
                targos d73d8ab
              
                deps: define V8_PRESERVE_MOST as no-op on Windows
              
              
                StefanStojanovic a435680
              
                deps: remove problematic comment from v8-internal
              
              
                targos 2025345
              
                deps: patch V8 to fix armv7 build
              
              
                targos a625a98
              
                deps: patch V8 13.4 to support compilation with MSVC
              
              
                StefanStojanovic 517d514
              
                deps: silence internal V8 deprecation warning
              
              
                targos a546d83
              
                deps: V8: cherry-pick a580b463ac35
              
              
                joyeecheung 59a87d1
              
                deps: V8: backport 2a23d9fa5217
              
              
                anonrig 3b25814
              
                deps: V8: backport c24df23717b6
              
              
                legendecas 950060b
              
                deps: V8: cherry-pick c172ffc5bf54
              
              
                tunz 58b1ea4
              
                build: remove support for s390 32-bit
              
              
                richardlau e47a369
              
                build: enable shared RO heap with ptr compression
              
              
                targos a9842d4
              
                tools: update V8 gypfiles for 13.1
              
              
                targos 97a3cfc
              
                tools: update V8 gypfiles for 13.2
              
              
                targos 38403e2
              
                build,src,tools: adapt build config for V8 13.3
              
              
                targos a5e14b5
              
                tools: update V8 gypfiles for 13.4
              
              
                targos fadba44
              
                build: add `/bigobj` to compile V8 on Windows
              
              
                targos f50c28c
              
                src: replace uses of FastApiTypedArray
              
              
                targos 0d0c8ae
              
                Revert "test: disable fast API call count checks"
              
              
                targos 4bb419b
              
                test: update test-linux-perf-logger
              
              
                targos 2f3618e
              
                test: adapt assert tests to stack trace changes
              
              
                targos f9168fc
              
                test: handle explicit resource management globals
              
              
                targos a1abd03
              
                deps: remove deps/simdutf
              
              
                targos ab90d04
              
                tools: update license-builder and LICENSE for V8 deps
              
              
                targos 160062e
              
                src: use `v8::ExternalMemoryAccounter`
              
              
                targos 6764e4a
              
                src,test: add V8 API to test the hash seed
              
              
                targos 489cf80
              
                build: pass `-fPIC` to linker as well for shared builds
              
              
                targos 59feb96
              
                zlib: fix pointer alignment
              
              
                jhofstee 48b3aee
              
                build: fix V8 TLS config for shared lib builds
              
              
                targos File filter
Filter by extension
Conversations
          Failed to load comments.   
        
        
          
      Loading
        
  Jump to
        
          Jump to file
        
      
      
          Failed to load files.   
        
        
          
      Loading
        
  Diff view
Diff view
There are no files selected for viewing
  
    
      This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
      Learn more about bidirectional Unicode characters
    
  
  
    
              
              
      
      Oops, something went wrong.
        
    
  
  Add this suggestion to a batch that can be applied as a single commit.
  This suggestion is invalid because no changes were made to the code.
  Suggestions cannot be applied while the pull request is closed.
  Suggestions cannot be applied while viewing a subset of changes.
  Only one suggestion per line can be applied in a batch.
  Add this suggestion to a batch that can be applied as a single commit.
  Applying suggestions on deleted lines is not supported.
  You must change the existing code in this line in order to create a valid suggestion.
  Outdated suggestions cannot be applied.
  This suggestion has been applied or marked resolved.
  Suggestions cannot be applied from pending reviews.
  Suggestions cannot be applied on multi-line comments.
  Suggestions cannot be applied while the pull request is queued to merge.
  Suggestion cannot be applied right now. Please check back later.
  
    
  
    
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think the convention is using
node_shared=="true".