meta: set startup team as config owners#57174
Closed
marco-ippolito wants to merge 1 commit intonodejs:mainfrom
Closed
meta: set startup team as config owners#57174marco-ippolito wants to merge 1 commit intonodejs:mainfrom
marco-ippolito wants to merge 1 commit intonodejs:mainfrom
Conversation
Collaborator
|
Review requested:
|
nodejs-github-bot
added
the
meta
Member
|
I think the startup team was created for startup snapshots and performance: #35215. I feel a dedicated team could better serve the intention here, with both config and dotenv in scope. |
anonrig
approved these changes
Feb 22, 2025
Member
anonrig
left a comment
anonrig
left a comment
There was a problem hiding this comment.
Let's add dotenv as well. LGTM
RafaelGSS
approved these changes
Feb 22, 2025
Member
Author
|
@legendecas I'll create another team then |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Use @nodejs/startup as team owner for config-file.
@anonrig maybe we should also add dotenv here.
(I'll add myself to team team if approved)