fix: Use of a weak cryptographic key

[odaysec]

node/benchmark/crypto/keygen.js

Lines 45 to 48 in 72aa2ea

	generateKeyPairSync('dsa', {
	modulusLength: 1024,
	divisorLength: 160,
	});

Modern encryption relies on it being computationally infeasible to break the cipher and decode a message without the key. As computational power increases, the ability to break ciphers grows and keys need to become larger.

References

RSA
AES
NodeJS
Recommendation for Transitioning the Use of Cryptographic Algorithms and Key Lengths
Key size
CWE-326

[nodejs-github-bot]

Review requested:

• @nodejs/performance

[aduh95]

Does it matter for a benchmark though?

[mcollina]

I'm not sure this matter at all.

However an argument can be made that it represents a more real benchmark.

[tniessen]

It does not matter, except that OpenSSL might at some point reject these parameters.

On a side note, neither DSA nor RSA are particularly future-proof algorithms, and at the same time, both have slow key generation, so benchmarking only these two seems like an odd choice.