Update collationruleparser.h #57629
Closed
Update collationruleparser.h #57629
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Refactor and improve the CollationRuleParser code: - Renamed constants for better clarity. - Used `constexpr` for constant expressions to improve performance. - Added detailed comments and documentation for better understanding. - Split complex functions into smaller, more manageable pieces. - Removed unused variables and cleaned up the code.
Collaborator
|
Review requested:
|
nodejs-github-bot
added
dependencies
RaisinTen
requested changes
Mar 26, 2025
Member
RaisinTen
left a comment
RaisinTen
left a comment
There was a problem hiding this comment.
Thanks for the PR but this is a code change in a vendored dependency which is supposed to be submitted upstream, so consider sending it to https://github.com/unicode-org/icu
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactor and improve the CollationRuleParser code:
constexprfor constant expressions to improve performance.