Skip to content

lib: avoid StackOverflow on serializeError #58075

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 29, 2025
Merged

lib: avoid StackOverflow on serializeError #58075

merged 1 commit into from
Apr 29, 2025

Conversation

@legendecas
Copy link
Member

serializeError should avoid StackOverflow and the test should not
rely on --stack-size.

Refs: #58070 (comment)

@legendecas
lib: avoid StackOverflow on serializeError
19bcef7 
`serializeError` should avoid StackOverflow and the test should not
rely on `--stack-size`.
@nodejs-github-bot nodejs-github-bot added the needs-ci PRs that need a full CI run. label Apr 29, 2025
@legendecas legendecas mentioned this pull request Apr 29, 2025
Closed
@aduh95 aduh95 added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. request-ci Add this label to start a Jenkins CI on a PR. labels Apr 29, 2025
@joyeecheung joyeecheung removed the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Apr 29, 2025
@aduh95 aduh95 added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Apr 29, 2025
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Apr 29, 2025
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/66506/

@codecov
Copy link

codecov bot commented Apr 29, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.22%. Comparing base (a36981a) to head (19bcef7).
Report is 11 commits behind head on main.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main   #58075   +/-   ##
=======================================
  Coverage   90.21%   90.22%           
=======================================
  Files         630      630           
  Lines      186391   186403   +12     
  Branches    36608    36612    +4     
=======================================
+ Hits       168161   168173   +12     
- Misses      11052    11059    +7     
+ Partials     7178     7171    -7
Files with missing lines Coverage Δ
lib/internal/error_serdes.js 98.51% <100.00%> (-0.44%) ⬇️

... and 43 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/66507/

@aduh95 aduh95 added the fast-track PRs that do not need to wait for 48 hours to land. label Apr 29, 2025
@github-actions
Copy link
Contributor

Fast-track has been requested by @aduh95. Please 👍 to approve.

@targos targos added the commit-queue Add this label to land a pull request using GitHub Actions. label Apr 29, 2025
@targos targos mentioned this pull request Apr 29, 2025
Merged
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Apr 29, 2025
@nodejs-github-bot nodejs-github-bot merged commit a7cbb90 into nodejs:main Apr 29, 2025
77 checks passed
@nodejs-github-bot
Copy link
Collaborator

Landed in a7cbb90

@legendecas legendecas deleted the error-serdes branch May 1, 2025 01:51
RafaelGSS pushed a commit that referenced this pull request May 1, 2025
@legendecas @RafaelGSS
lib: avoid StackOverflow on serializeError
09e8c88 
`serializeError` should avoid StackOverflow and the test should not
rely on `--stack-size`.

PR-URL: #58075
Reviewed-By: Yagiz Nizipli <[email protected]>
Reviewed-By: Antoine du Hamel <[email protected]>
Reviewed-By: Joyee Cheung <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
Reviewed-By: Rafael Gonzaga <[email protected]>
RafaelGSS pushed a commit that referenced this pull request May 2, 2025
@legendecas @RafaelGSS
lib: avoid StackOverflow on serializeError
398674a 
`serializeError` should avoid StackOverflow and the test should not
rely on `--stack-size`.

PR-URL: #58075
Reviewed-By: Yagiz Nizipli <[email protected]>
Reviewed-By: Antoine du Hamel <[email protected]>
Reviewed-By: Joyee Cheung <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
Reviewed-By: Rafael Gonzaga <[email protected]>
aduh95 pushed a commit that referenced this pull request May 6, 2025
@legendecas @aduh95
lib: avoid StackOverflow on serializeError
f7b9315 
`serializeError` should avoid StackOverflow and the test should not
rely on `--stack-size`.

PR-URL: #58075
Reviewed-By: Yagiz Nizipli <[email protected]>
Reviewed-By: Antoine du Hamel <[email protected]>
Reviewed-By: Joyee Cheung <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
Reviewed-By: Rafael Gonzaga <[email protected]>
aduh95 pushed a commit that referenced this pull request May 6, 2025
@legendecas @aduh95
lib: avoid StackOverflow on serializeError
6194254 
`serializeError` should avoid StackOverflow and the test should not
rely on `--stack-size`.

PR-URL: #58075
Reviewed-By: Yagiz Nizipli <[email protected]>
Reviewed-By: Antoine du Hamel <[email protected]>
Reviewed-By: Joyee Cheung <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
Reviewed-By: Rafael Gonzaga <[email protected]>
RafaelGSS pushed a commit that referenced this pull request May 14, 2025
@legendecas @RafaelGSS
lib: avoid StackOverflow on serializeError
f1c2430 
`serializeError` should avoid StackOverflow and the test should not
rely on `--stack-size`.

PR-URL: #58075
Reviewed-By: Yagiz Nizipli <[email protected]>
Reviewed-By: Antoine du Hamel <[email protected]>
Reviewed-By: Joyee Cheung <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
Reviewed-By: Rafael Gonzaga <[email protected]>
aduh95 pushed a commit that referenced this pull request May 16, 2025
@legendecas @aduh95
lib: avoid StackOverflow on serializeError
ed1bb8a 
`serializeError` should avoid StackOverflow and the test should not
rely on `--stack-size`.

PR-URL: #58075
Reviewed-By: Yagiz Nizipli <[email protected]>
Reviewed-By: Antoine du Hamel <[email protected]>
Reviewed-By: Joyee Cheung <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
Reviewed-By: Rafael Gonzaga <[email protected]>
aduh95 pushed a commit that referenced this pull request May 17, 2025
@legendecas @aduh95
lib: avoid StackOverflow on serializeError
2332dfe 
`serializeError` should avoid StackOverflow and the test should not
rely on `--stack-size`.

PR-URL: #58075
Reviewed-By: Yagiz Nizipli <[email protected]>
Reviewed-By: Antoine du Hamel <[email protected]>
Reviewed-By: Joyee Cheung <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
Reviewed-By: Rafael Gonzaga <[email protected]>
aduh95 pushed a commit that referenced this pull request May 17, 2025
@legendecas @aduh95
lib: avoid StackOverflow on serializeError
4d7065c 
`serializeError` should avoid StackOverflow and the test should not
rely on `--stack-size`.

PR-URL: #58075
Reviewed-By: Yagiz Nizipli <[email protected]>
Reviewed-By: Antoine du Hamel <[email protected]>
Reviewed-By: Joyee Cheung <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
Reviewed-By: Rafael Gonzaga <[email protected]>
aduh95 pushed a commit that referenced this pull request May 17, 2025
@legendecas @aduh95
lib: avoid StackOverflow on serializeError
c4eed6f 
`serializeError` should avoid StackOverflow and the test should not
rely on `--stack-size`.

PR-URL: #58075
Reviewed-By: Yagiz Nizipli <[email protected]>
Reviewed-By: Antoine du Hamel <[email protected]>
Reviewed-By: Joyee Cheung <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
Reviewed-By: Rafael Gonzaga <[email protected]>
aduh95 pushed a commit that referenced this pull request May 18, 2025
@legendecas @aduh95
lib: avoid StackOverflow on serializeError
a5e7c75 
`serializeError` should avoid StackOverflow and the test should not
rely on `--stack-size`.

PR-URL: #58075
Reviewed-By: Yagiz Nizipli <[email protected]>
Reviewed-By: Antoine du Hamel <[email protected]>
Reviewed-By: Joyee Cheung <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
Reviewed-By: Rafael Gonzaga <[email protected]>
@github-actions github-actions bot mentioned this pull request May 19, 2025
Merged
aduh95 pushed a commit that referenced this pull request May 19, 2025
@legendecas @aduh95
lib: avoid StackOverflow on serializeError
d9700fe 
`serializeError` should avoid StackOverflow and the test should not
rely on `--stack-size`.

PR-URL: #58075
Reviewed-By: Yagiz Nizipli <[email protected]>
Reviewed-By: Antoine du Hamel <[email protected]>
Reviewed-By: Joyee Cheung <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
Reviewed-By: Rafael Gonzaga <[email protected]>
@ghost ghost mentioned this pull request Jun 8, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@anonrig anonrig anonrig approved these changes

@joyeecheung joyeecheung joyeecheung approved these changes

@BridgeAR BridgeAR BridgeAR approved these changes

@aduh95 aduh95 aduh95 approved these changes

@RafaelGSS RafaelGSS RafaelGSS approved these changes

Assignees

No one assigned

Labels

author ready PRs that have at least one approval, no pending requests for changes, and a CI started. fast-track PRs that do not need to wait for 48 hours to land. needs-ci PRs that need a full CI run.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

8 participants

@legendecas @nodejs-github-bot @anonrig @joyeecheung @BridgeAR @aduh95 @RafaelGSS @targos