- 
          
- 
                Notifications
    You must be signed in to change notification settings 
- Fork 33.6k
[v20.x] test: skip broken sea on rhel8 #58761
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
          
     Closed
      
      
            marco-ippolito
  wants to merge
  1
  commit into
  nodejs:v20.x-staging
from
marco-ippolito:skip-flakes-rhel8
  
      
      
   
      
    
                
     Closed
            
            [v20.x] test: skip broken sea on rhel8 #58761
                    marco-ippolito
  wants to merge
  1
  commit into
  nodejs:v20.x-staging
from
marco-ippolito:skip-flakes-rhel8
  
      
      
   
              
            Conversation
  
    
      This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
      Learn more about bidirectional Unicode characters
    
  
  
    
    
              
                    panva
  
              
              approved these changes
              
                  
                    Jun 19, 2025 
                  
              
              
            
            
      
     Merged
  
| Fast-track has been requested by @panva. Please 👍 to approve. | 
              
                    RaisinTen
  
              
              reviewed
              
                  
                    Jun 19, 2025 
                  
              
              
            
            
              
                    mcollina
  
              
              approved these changes
              
                  
                    Jun 19, 2025 
                  
              
              
            
            
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
6518711    to
    ed241a4      
    Compare
  
    
              
                    richardlau
  
              
              approved these changes
              
                  
                    Jun 19, 2025 
                  
              
              
            
            
              
                    anonrig
  
              
              approved these changes
              
                  
                    Jun 19, 2025 
                  
              
              
            
            
              
                    RaisinTen
  
              
              approved these changes
              
                  
                    Jun 19, 2025 
                  
              
              
            
            
              
                    mhdawson
  
              
              approved these changes
              
                  
                    Jun 19, 2025 
                  
              
              
            
            
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
    
  marco-ippolito 
      added a commit
      that referenced
      this pull request
    
      Jun 20, 2025 
    
    
      
  
    
      
    
  
PR-URL: #58761 Refs: #58588 Reviewed-By: Filip Skokan <[email protected]> Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Yagiz Nizipli <[email protected]> Reviewed-By: Darshan Sen <[email protected]> Reviewed-By: Michael Dawson <[email protected]>
| Landed in 850192b | 
    
  marco-ippolito 
      added a commit
        to marco-ippolito/node
      that referenced
      this pull request
    
      Jul 1, 2025 
    
    
      
  
    
      
    
  
PR-URL: nodejs#58761 Refs: nodejs#58588 Reviewed-By: Filip Skokan <[email protected]> Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Yagiz Nizipli <[email protected]> Reviewed-By: Darshan Sen <[email protected]> Reviewed-By: Michael Dawson <[email protected]>
    
  marco-ippolito 
      added a commit
        to marco-ippolito/node
      that referenced
      this pull request
    
      Jul 1, 2025 
    
    
      
  
    
      
    
  
PR-URL: nodejs#58761 Refs: nodejs#58588 Reviewed-By: Filip Skokan <[email protected]> Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Yagiz Nizipli <[email protected]> Reviewed-By: Darshan Sen <[email protected]> Reviewed-By: Michael Dawson <[email protected]>
  This was referenced Aug 15, 2025 
      
  
    Sign up for free
    to join this conversation on GitHub.
    Already have an account?
    Sign in to comment
  
      Labels
      
    fast-track
  PRs that do not need to wait for 48 hours to land. 
  
    needs-ci
  PRs that need a full CI run. 
  
    test
  Issues and PRs related to the tests. 
  
    v20.x
  Issues that can be reproduced on v20.x or PRs targeting the v20.x-staging branch. 
  Add this suggestion to a batch that can be applied as a single commit.
  This suggestion is invalid because no changes were made to the code.
  Suggestions cannot be applied while the pull request is closed.
  Suggestions cannot be applied while viewing a subset of changes.
  Only one suggestion per line can be applied in a batch.
  Add this suggestion to a batch that can be applied as a single commit.
  Applying suggestions on deleted lines is not supported.
  You must change the existing code in this line in order to create a valid suggestion.
  Outdated suggestions cannot be applied.
  This suggestion has been applied or marked resolved.
  Suggestions cannot be applied from pending reviews.
  Suggestions cannot be applied on multi-line comments.
  Suggestions cannot be applied while the pull request is queued to merge.
  Suggestion cannot be applied right now. Please check back later.
  
    
  
    
Refs: #58588
Should unblock the v20 release