dgram: add option for using recvmmsg #59126
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
Review requested:
|
nodejs-github-bot
added
c++
theanarkh
changed the title
theanarkh
force-pushed
the
support_using_recvmmsg
branch
from
ecc5df0 to
fd1ca64
Compare
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #59126 +/- ##
==========================================
- Coverage 90.06% 88.55% -1.51%
==========================================
Files 645 704 +59
Lines 189130 208142 +19012
Branches 37094 40027 +2933
==========================================
+ Hits 170339 184323 +13984
- Misses 11511 15828 +4317
- Partials 7280 7991 +711
🚀 New features to boost your workflow:
|
theanarkh
force-pushed
the
support_using_recvmmsg
branch
from
fd1ca64 to
d09c31a
Compare
addaleax
reviewed
Oct 6, 2025
src/udp_wrap.cc
Outdated
Member
There was a problem hiding this comment.
Can these fieds be initialized as part of the constructor member initializer list or inline in the member declaration?
Member
There was a problem hiding this comment.
What if this multiplication overflows?
src/udp_wrap.cc
Outdated
Member
There was a problem hiding this comment.
Can we CHECK() in this case that mmsg_buf_ is empty?
src/udp_wrap.h
Outdated
theanarkh
force-pushed
the
support_using_recvmmsg
branch
from
d09c31a to
89c252e
Compare
Contributor
Author
|
@addaleax Thanks for your review ! I have updated the code. |
theanarkh
force-pushed
the
support_using_recvmmsg
branch
from
89c252e to
aac2964
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add an option for using
recvmmsg.make -j4 test(UNIX), orvcbuild test(Windows) passes