Skip to content

doc: make documentation menu background transparent #59413

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

tawseefnabi
Copy link

  • Set transparent background for menu in both light and dark modes
  • Adjusted text colors for better contrast
  • Light mode: rgba(0, 0, 0, 0.1) background with dark text
  • Dark mode: rgba(255, 255, 255, 0.1) background with white text

- Set transparent background for menu in both light and dark modes
- Adjusted text colors for better contrast
- Light mode: rgba(0, 0, 0, 0.1) background with dark text
- Dark mode: rgba(255, 255, 255, 0.1) background with white text
@nodejs-github-bot
Copy link
Collaborator

Review requested:

  • @nodejs/nodejs-website

@nodejs-github-bot nodejs-github-bot added the doc Issues and PRs related to the documentations. label Aug 9, 2025
@avivkeller
Copy link
Member

Can you provide a before/after screenshot comparison?

@tawseefnabi
Copy link
Author

Hi @avivkeller
this is before
Screenshot 2025-08-09 at 5 59 51 PM

this is after changes

Screenshot 2025-08-09 at 9 31 48 PM

Copy link
Member

@avivkeller avivkeller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just checked the current documentation:

Image

I don't see an issue

@bjohansebas
Copy link
Member

I don’t see the issue either. What browser are you using @tawseefnabi ?

@tawseefnabi
Copy link
Author

I don’t see the issue either. What browser are you using @tawseefnabi ?

@bjohansebas @avivkeller
issue was reported here
#59282

@avivkeller
Copy link
Member

Yes, we see that, however, we can't reproduce it, can you?

Copy link
Member

@gurgunday gurgunday left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can't reproduce it either

@dario-piotrowicz
Copy link
Member

I can reproduce the issue, it seems to happen only on screens with width <= 600px:
Screenshot 2025-08-10 at 21 49 20

@dario-piotrowicz
Copy link
Member

dario-piotrowicz commented Aug 10, 2025

Thanks for the PR @tawseefnabi 🙂

Have you considered simply adding a z-index: 1 to the picker class instead?

.picker {

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
doc Issues and PRs related to the documentations.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants