Skip to content

path: change win32.join to use array #59781

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
nodejs-github-bot merged 2 commits into from
Sep 8, 2025
Merged

path: change win32.join to use array #59781

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b77afc0
path: refactor path joining logic for clarity and performance
wlgh1553 Sep 6, 2025
f1f2e05
refactor: use ArrayPrototypePush for path array manipulation
wlgh1553 Sep 6, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 6 additions & 7 deletions lib/path.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -506,21 +506,20 @@
if (args.length === 0)
return '.';

let joined;
let firstPart;
const path = [];
for (let i = 0; i < args.length; ++i) {
const arg = args[i];
validateString(arg, 'path');
if (arg.length > 0) {
if (joined === undefined)
joined = firstPart = arg;
else
joined += `\\${arg}`;
path.push(arg);
Copy link
Contributor

@aduh95 aduh95 Sep 6, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
path.push(arg);
ArrayPrototypePush(path, arg);

Copy link
Contributor Author

@wlgh1553 wlgh1553 Sep 6, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your review!
f1f2e05

}
}

if (joined === undefined)
if (path.length === 0)
return '.';

Check failure on line 520 in lib/path.js

View workflow job for this annotation

GitHub Actions / lint-js-and-md 

Trailing spaces not allowed
const firstPart = path[0];
let joined = ArrayPrototypeJoin(path, '\\');

// Make sure that the joined path doesn't start with two slashes, because
// normalize() will mistake it for a UNC path then.
Expand Down
Loading