-
-
Notifications
You must be signed in to change notification settings - Fork 34.3k
Benchmark/add workflow to test all configs #59919
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
brunocroh
wants to merge
5
commits into
nodejs:main
Choose a base branch
from
brunocroh:benchmark/add-workflow-to-test-all-configs
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Benchmark/add workflow to test all configs #59919
brunocroh
wants to merge
5
commits into
nodejs:main
from
brunocroh:benchmark/add-workflow-to-test-all-configs
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
Review requested:
|
Member
Author
|
@RafaelGSS I think the requirements for adding the new workflow are covered here, but I'll probably need some guidance on creating the workflow itself. Let me know if I've missed anything here. |
b05e911 to
f560cd7
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #59919 +/- ##
==========================================
- Coverage 88.27% 88.25% -0.02%
==========================================
Files 703 703
Lines 207333 207333
Branches 39875 39876 +1
==========================================
- Hits 183028 182990 -38
- Misses 16263 16301 +38
Partials 8042 8042 🚀 New features to boost your workflow:
|
The env NODE_RUN_ALL_BENCH_TESTS was introduced to enable benchmark tests to run all configs when it is passed. Some tests that have file names different from the original benchmark were using dashes in places that needed underscores and have been renamed. Some benchmarks that did not have tests were created. These are: - test/benchmark/test-benchmark-abort_controller.js - test/benchmark/test-benchmark-error.js - test/benchmark/test-benchmark-https.js - test/benchmark/test-benchmark-perf_hooks.js - test/benchmark/test-benchmark-permission.js - test/benchmark/test-benchmark-sqlite.js - test/benchmark/test-benchmark-test_runner.js - test/benchmark/test-benchmark-webstorage.js
137a84d to
14f0ef7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR introduces the usage of a new environment variable
NODE_RUN_ALL_BENCH_TESTS, which can be set to run all benchmark configurations in tests to cover more scenarios where benchmarks might fail.Add more context to docs about how to write benchmark tests
and provides more details about the environment variables:
Benchmark tests were added for the following groups:
Additionally, some inconsistent test files were renamed: