Skip to content

test: deflake test-fs-promises-watch-iterator #60060

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
+3 −1
Open

test: deflake test-fs-promises-watch-iterator #60060

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion test/parallel/test-fs-promises-watch-iterator.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,10 +34,12 @@ class WatchTestCase {
}
}
async writeFiles() {
// Do the write with a delay to ensure that the OS is ready to notify us.
await setTimeout(common.platformTimeout(100));
Comment on lines +37 to +38
Copy link
Member Author

@lpinca lpinca Sep 28, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The same is done in other fs.watch() tests, for example:

node/test/parallel/test-fs-watch-recursive-add-file.js

Lines 41 to 44 in c6316f9

// Do the write with a delay to ensure that the OS is ready to notify us.
setTimeout(() => {
fs.writeFileSync(testFile, 'world');
}, common.platformTimeout(200));

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this deserves a TODO to investigate why this is occuring and whether or not this is a bug.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There already an open issue (#52601) linked in the commit message.


for (const fileName of [...this.files]) {
await writeFile(this.filePath(fileName), Date.now() + fileName.repeat(1e4));
}
await setTimeout(common.platformTimeout(100));
Copy link
Member Author

@lpinca lpinca Sep 28, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If there was a reason for this I will add it back, but I don't see it.

}
}

Expand Down
Loading