util: do not print getters as regular property using inspect #60131
+103
−79
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
needs-ci
This makes sure special properties (such as a byteLength, buffer, and more) are marked that they are not regular properties. They are mostly getters, that just seemed even more of a breaking change. Thus, they just use square brackets for now. On top of that, it makes inspecting detached DataViews robust. Inspecting those failed so far. Closes: nodejs#56669
BridgeAR
force-pushed
the
2025-10-06-util-inspect-improvements
branch
from
a4d876f to
6599727
Compare
This comment was marked as resolved.
This comment was marked as resolved.
BridgeAR
changed the title
BridgeAR
changed the title
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #60131 +/- ##
==========================================
+ Coverage 88.52% 88.53% +0.01%
==========================================
Files 703 703
Lines 207825 207822 -3
Branches 40003 40011 +8
==========================================
+ Hits 183976 184001 +25
+ Misses 15862 15818 -44
- Partials 7987 8003 +16
🚀 New features to boost your workflow:
|
ljharb
approved these changes
Oct 8, 2025
BridgeAR
added
author ready
github-actions
bot
removed
the
request-ci
aduh95
approved these changes
Oct 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes sure special properties (such as a byteLength, buffer, and more) are marked that they are not regular properties. They are mostly getters, that just seemed even more of a breaking change. Thus, they just use square brackets for now.
On top of that, it makes inspecting detached DataViews robust. Inspecting those failed so far.
Closes: #56669