src: use ToLocal() in napi_create_bigint_words

[ri7116]

Replace ToLocalChecked() with MaybeLocal::ToLocal() for BigInt::NewFromWords.
On failure, return napi_set_last_error(env, napi_generic_failure) to correctly propagate the error instead of risking a crash.
This aligns with existing error-handling macros and avoids unchecked conversions.

[nodejs-github-bot]

Review requested:

• @nodejs/node-api

[legendecas]

CHECK_MAYBE_EMPTY_WITH_PREAMBLE should already handles the empty result from v8::BigInt::NewFromWords.

Could you clarify how this change is different from CHECK_MAYBE_EMPTY_WITH_PREAMBLE?

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 88.54%. Comparing base (0fb0406) to head (3d03c6e).
⚠️ Report is 3 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff             @@
##             main   #60165      +/-   ##
==========================================
- Coverage   88.55%   88.54%   -0.01%     
==========================================
  Files         704      704              
  Lines      208089   208091       +2     
  Branches    40017    40015       -2     
==========================================
- Hits       184270   184262       -8     
- Misses      15818    15861      +43     
+ Partials     8001     7968      -33     

Files with missing lines	Coverage Δ
src/js_native_api_v8.cc	76.52% <100.00%> (+0.02%)	⬆️

... and 36 files with indirect coverage changes

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[ri7116]

CHECK_MAYBE_EMPTY_WITH_PREAMBLE should already handles the empty result from v8::BigInt::NewFromWords.

Could you clarify how this change is different from CHECK_MAYBE_EMPTY_WITH_PREAMBLE?

Thank you for clarifying, It seems I misunderstood. Just to confirm, is it correct to say that ToLocalChecked() is safe to use as long as the value has been validated beforehand?"

[legendecas]

Just to confirm, is it correct to say that ToLocalChecked() is safe to use as long as the value has been validated beforehand?"

Yes, it is corret. For cases, we would recommend ToLocal combined with an if branch to reduce the checks. And in conditions like during bootstrap, we would also use ToLocalChecked() when we don't expect a value to be empty otherwise it should crash immediately.