Skip to content

http: simplify getName with destructuring and template literals #60350

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Ayoub-Mabrouk wants to merge 1 commit into
base: main
Choose a base branch
from
Open

http: simplify getName with destructuring and template literals #60350

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 6 additions & 13 deletions lib/_http_agent.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -259,23 +259,16 @@ Agent.prototype.createConnection = function createConnection(...args) {

// Get the key for a given set of request options
Agent.prototype.getName = function getName(options = kEmptyObject) {
let name = options.host || 'localhost';

name += ':';
if (options.port)
name += options.port;

name += ':';
if (options.localAddress)
name += options.localAddress;
const { host = 'localhost', port, localAddress, family, socketPath } = options;
let name = `${host}:${port || ''}:${localAddress || ''}`;

// Pacify parallel/test-http-agent-getname by only appending
// the ':' when options.family is set.
if (options.family === 4 || options.family === 6)
name += `:${options.family}`;
if (family === 4 || family === 6)
name += `:${family}`;

if (options.socketPath)
name += `:${options.socketPath}`;
if (socketPath)
name += `:${socketPath}`;

return name;
};
Expand Down